Bug 153614 - Modern IDB: SQLite backend doesn't handle mutation during cursor iteration
Summary: Modern IDB: SQLite backend doesn't handle mutation during cursor iteration
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 149117 153021
  Show dependency treegraph
 
Reported: 2016-01-28 13:44 PST by Brady Eidson
Modified: 2016-01-28 14:54 PST (History)
4 users (show)

See Also:


Attachments
Patch v1 (7.78 KB, patch)
2016-01-28 14:47 PST, Brady Eidson
achristensen: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2016-01-28 13:44:54 PST
Modern IDB: SQLite backend doesn't handle mutation during cursor iteration
Comment 1 Brady Eidson 2016-01-28 14:47:33 PST
Created attachment 270147 [details]
Patch v1
Comment 2 Brady Eidson 2016-01-28 14:53:47 PST
http://trac.webkit.org/changeset/195784
Comment 3 Andy Estes 2016-01-28 14:54:48 PST
Comment on attachment 270147 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=270147&action=review

> Source/WebCore/Modules/indexeddb/server/SQLiteIDBTransaction.cpp:137
> +    auto backingStoreTake = m_backingStoreCursors.take(&cursor);
> +    if (backingStoreTake) {

How about if (auto* takenBackingStore = m_backingStoreCursors.take(&cursor)) {

takenBackingStore seems like a better name than backingStoreTake.