Bug 153608 - Web Inspector: Avoid recreating Timeline's DataGridNode data multiple times
Summary: Web Inspector: Avoid recreating Timeline's DataGridNode data multiple times
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-01-28 11:38 PST by Joseph Pecoraro
Modified: 2016-01-28 13:07 PST (History)
8 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (6.99 KB, patch)
2016-01-28 11:38 PST, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-01-28 11:38:04 PST
* SUMMARY
Avoid recreating Timeline's DataGridNode data multiple times

Many TimelineDataGridNode subclasses do something like:

    get data()
    {
        // some work
        return {
          ...
        };
    }

    createCellContent(columnIdentifier, cell)
    {
        // Invoke the `data` getter above to create the object...
        var value = this.data[columnIdentifier];
    }

We should avoid recreating lots of objects in data. Lets do it once and cache it.
Comment 1 Radar WebKit Bug Importer 2016-01-28 11:38:36 PST
<rdar://problem/24393701>
Comment 2 Joseph Pecoraro 2016-01-28 11:38:53 PST
Created attachment 270135 [details]
[PATCH] Proposed Fix
Comment 3 WebKit Commit Bot 2016-01-28 13:06:58 PST
Comment on attachment 270135 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 270135

Committed r195779: <http://trac.webkit.org/changeset/195779>
Comment 4 WebKit Commit Bot 2016-01-28 13:07:02 PST
All reviewed patches have been landed.  Closing bug.