Bug 153601 - [GTK][EFL] Make gtk & efl port use s same media controls code.
Summary: [GTK][EFL] Make gtk & efl port use s same media controls code.
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-28 10:51 PST by ChangSeok Oh
Modified: 2017-03-11 11:10 PST (History)
6 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description ChangSeok Oh 2016-01-28 10:51:30 PST
In bug 151816, Xabier mentioned his thought on merging mediaControlsGtk.js and mediaControlsBase.js and making gtk & efl port use a same code base, mediaControlsBase.js. This is a follow-up.
Comment 1 Xabier Rodríguez Calvar 2016-01-29 00:34:06 PST
Ossy, we were discussing about merging EFL and GTK+ media controls since you are using Base, that is a fork of an earlier version of the Apple ones.

The discussion is under https://bugs.webkit.org/show_bug.cgi?id=151816#c19.

I could take care of the review and such, but since we are changing your look and feel, you might want to say a word :)
Comment 2 Csaba Osztrogonác 2016-01-29 00:39:14 PST
I don't have any time nowadays, maybe the others have some opinion about it.
Comment 3 Gyuyoung Kim 2016-01-29 19:15:29 PST
(In reply to comment #2)
> I don't have any time nowadays, maybe the others have some opinion about it.

I post a comment there.
https://bugs.webkit.org/show_bug.cgi?id=151816#c28
Comment 4 Xabier Rodríguez Calvar 2016-01-30 08:20:05 PST
Answering the comment in bug 151816.

(In reply to comment #28)
> Basically I think the way is that we go. EFL had owned media control theme.
> But it was very poor quality controls. That's why we have used Apple's base
> media control themes. If EFL is continue to use base theme without GTK
> dependency when merging base + GTK+, I don't have any reason to object this
> plan.

If you don't have issues now, you shouldn't have them after the merge. The only issues might be some icons or things like that, that can be easily solved with CSS or theming.

Anyway, the way to go, IMHO, would be to make the merge directly into, mediaControlsGTK, make GTK+ use only that file instead of Base+GTK and once that is ready, we can rename that into Base and polish any details in EFL. That would allow working only in one port until everything is ready.
Comment 5 Michael Catanzaro 2017-03-11 11:10:13 PST
EFL port has been removed.