Click on some type of data detector links should not trigger a navigation request.
Created attachment 270129 [details] Patch
Comment on attachment 270129 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270129&action=review > Source/WebCore/editing/cocoa/DataDetection.mm:66 > +#if PLATFORM(MAC) None of this code seems iOS specific? > Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:682 > + requestPositionInformation(IntPoint((CGPoint)m_potentialTapLocation)); Why are you going FloatPoint->CGPoint->IntPoint? You should probably use one of the FloatPoint->IntPoint conversion functions (roundedIntPoint?)
(In reply to comment #2) > Comment on attachment 270129 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=270129&action=review > > > Source/WebCore/editing/cocoa/DataDetection.mm:66 > > +#if PLATFORM(MAC) > > None of this code seems iOS specific? It is not, but this behavior is iOS specific. Al least for now. > > > Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:682 > > + requestPositionInformation(IntPoint((CGPoint)m_potentialTapLocation)); > > Why are you going FloatPoint->CGPoint->IntPoint? You should probably use one > of the FloatPoint->IntPoint conversion functions (roundedIntPoint?) Right! I forgot about that. Will fix it.
Committed revision 195769.