Bug 153599 - Move attributes to the prototype for List types / and types with indexed/named property getters
Summary: Move attributes to the prototype for List types / and types with indexed/name...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar, WebExposed
Depends on:
Blocks:
 
Reported: 2016-01-28 10:27 PST by Chris Dumez
Modified: 2016-01-28 19:42 PST (History)
10 users (show)

See Also:


Attachments
Patch (35.88 KB, patch)
2016-01-28 10:29 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-yosemite (1.24 MB, application/zip)
2016-01-28 14:24 PST, Build Bot
no flags Details
Patch (36.02 KB, patch)
2016-01-28 16:05 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-01-28 10:27:20 PST
Move attributes to the prototype for List types / and types with indexed/named property getters.

We used to keep them on the instance because:
1. Our GetOwnProperty lookup used to be in incorrect order for interfaces with indexed/named property getters.
-> This was fixed recently and we now match the specification and other browsers.
2. This used to regress performance when iterating over those list types
-> Local testing seems to show that this is no longer a regression (tested Speedometer and various related Bindings PerformanceTests).
Comment 1 Chris Dumez 2016-01-28 10:29:52 PST
Created attachment 270126 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2016-01-28 10:34:05 PST
<rdar://problem/24391745>
Comment 3 Build Bot 2016-01-28 14:24:11 PST
Comment on attachment 270126 [details]
Patch

Attachment 270126 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/752198

New failing tests:
imported/w3c/web-platform-tests/html/dom/interfaces.html
Comment 4 Build Bot 2016-01-28 14:24:16 PST
Created attachment 270146 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 5 Chris Dumez 2016-01-28 16:05:31 PST
Created attachment 270157 [details]
Patch
Comment 6 WebKit Commit Bot 2016-01-28 19:42:50 PST
Comment on attachment 270157 [details]
Patch

Clearing flags on attachment: 270157

Committed r195798: <http://trac.webkit.org/changeset/195798>
Comment 7 WebKit Commit Bot 2016-01-28 19:42:57 PST
All reviewed patches have been landed.  Closing bug.