Bug 153599 – Move attributes to the prototype for List types / and types with indexed/named property getters

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Chris Dumez]

Move attributes to the prototype for List types / and types with indexed/named property getters.

We used to keep them on the instance because:
1. Our GetOwnProperty lookup used to be in incorrect order for interfaces with indexed/named property getters.
-> This was fixed recently and we now match the specification and other browsers.
2. This used to regress performance when iterating over those list types
-> Local testing seems to show that this is no longer a regression (tested Speedometer and various related Bindings PerformanceTests).

[Chris Dumez]

Created attachment 270126 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/24391745>

[Build Bot]

Comment on attachment 270126 [details]
Patch

Attachment 270126 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/752198

New failing tests:
imported/w3c/web-platform-tests/html/dom/interfaces.html

[Build Bot]

Created attachment 270146 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Chris Dumez]

Created attachment 270157 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 270157 [details]
Patch

Clearing flags on attachment: 270157

Committed r195798: <http://trac.webkit.org/changeset/195798>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.