Bug 153596 - Modern IDB: Index uniqueness broken in the SQLite backend
Summary: Modern IDB: Index uniqueness broken in the SQLite backend
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 149117 153021
  Show dependency tree / graph
 
Reported: 2016-01-28 09:42 PST by Brady Eidson
Modified: 2016-01-28 11:20 PST (History)
4 users (show)

See Also:

Attachments
Patch v1 (12.33 KB, patch)
2016-01-28 09:43 PST, Brady Eidson 		achristensen: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (12.22 KB, patch)
2016-01-28 10:56 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2016-01-28 09:42:10 PST 
Modern IDB: Index uniqueness broken in the SQLite backend
Comment 1 Brady Eidson 2016-01-28 09:43:33 PST 
Created attachment 270122 [details]
Patch v1
Comment 2 WebKit Commit Bot 2016-01-28 10:49:07 PST 
Comment on attachment 270122 [details]
Patch v1

Rejecting attachment 270122 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
rack.dia -c /Volumes/Data/EWS/WebKit/Source/WebCore/html/track/TextTrack.cpp -o /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/TextTrack.o

** BUILD FAILED **


The following build commands failed:
	CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/SQLiteIDBBackingStore.o Modules/indexeddb/server/SQLiteIDBBackingStore.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)

Full output: http://webkit-queues.webkit.org/results/751447
Comment 3 Brady Eidson 2016-01-28 10:56:07 PST 
Created attachment 270128 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2016-01-28 11:20:33 PST 
Comment on attachment 270128 [details]
Patch for landing

Clearing flags on attachment: 270128

Committed r195765: <http://trac.webkit.org/changeset/195765>
Comment 5 WebKit Commit Bot 2016-01-28 11:20:37 PST 
All reviewed patches have been landed.  Closing bug.