Bug 153595 - EventHandler IDL attributes should be enumerable
Summary: EventHandler IDL attributes should be enumerable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: WebExposed
Depends on:
Blocks:
 
Reported: 2016-01-28 09:08 PST by Chris Dumez
Modified: 2016-01-28 17:24 PST (History)
7 users (show)

See Also:

Attachments
Patch (33.76 KB, patch)
2016-01-28 09:39 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (33.82 KB, patch)
2016-01-28 09:46 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-01-28 09:08:48 PST 
Most of our EventHandler IDL attributes are marked as [NotEnumerable] but should not be according to the specification:
- https://html.spec.whatwg.org/#globaleventhandlers
- https://html.spec.whatwg.org/#windoweventhandlers

Firefox and Chrome behave according to the specification.
Comment 1 Chris Dumez 2016-01-28 09:39:53 PST 
Created attachment 270121 [details]
Patch
Comment 2 Chris Dumez 2016-01-28 09:46:15 PST 
Created attachment 270123 [details]
Patch
Comment 3 Sam Weinig 2016-01-28 10:14:55 PST 
Comment on attachment 270123 [details]
Patch

r=me. Do you know why these were marked [NotEnumerable] in the first place (there is good chance I did it and can't remember)?
Comment 4 Chris Dumez 2016-01-28 11:07:41 PST 
(In reply to comment #3)
> Comment on attachment 270123 [details]
> Patch
> 
> r=me. Do you know why these were marked [NotEnumerable] in the first place
> (there is good chance I did it and can't remember)?

It is not easy to tell because this was done a very long time ago and these have moved around.
Comment 5 WebKit Commit Bot 2016-01-28 12:35:26 PST 
Comment on attachment 270123 [details]
Patch

Clearing flags on attachment: 270123

Committed r195778: <http://trac.webkit.org/changeset/195778>
Comment 6 WebKit Commit Bot 2016-01-28 12:35:32 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Darin Adler 2016-01-28 17:23:53 PST 
Yes, Sam, you did it in http://trac.webkit.org/changeset/36977 and there is no indication why!
Comment 8 Darin Adler 2016-01-28 17:24:11 PST 
I was the reviewer.