Bug 153580 - [GStreamer] MediaPlayerPrivateGStreamerBase::handleSyncMessage leaks GstContext
Summary: [GStreamer] MediaPlayerPrivateGStreamerBase::handleSyncMessage leaks GstContext
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gwang Yoon Hwang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-27 21:13 PST by Gwang Yoon Hwang
Modified: 2016-07-06 09:01 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.87 KB, patch)
2016-01-27 21:16 PST, Gwang Yoon Hwang 		no flags Details | Formatted Diff | Diff
Patch (5.31 KB, patch)
2016-01-28 00:14 PST, Gwang Yoon Hwang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gwang Yoon Hwang 2016-01-27 21:13:29 PST 
[GStreamer] MediaPlayerPrivateGStreamerBase::handleSyncMessage leaks GstContext
Comment 1 Gwang Yoon Hwang 2016-01-27 21:16:49 PST 
Created attachment 270088 [details]
Patch
Comment 2 Philippe Normand 2016-01-27 23:56:39 PST 
Comment on attachment 270088 [details]
Patch

This actually needs GRefPtr template specialization for GstContext.
Comment 3 Gwang Yoon Hwang 2016-01-28 00:14:17 PST 
Created attachment 270098 [details]
Patch
Comment 4 Gwang Yoon Hwang 2016-01-28 00:14:57 PST 
(In reply to comment #2)
> Comment on attachment 270088 [details]
> Patch
> 
> This actually needs GRefPtr template specialization for GstContext.

Good point! Fixed to do that
Comment 5 Philippe Normand 2016-01-28 00:16:37 PST 
Comment on attachment 270098 [details]
Patch

Thanks :)
Comment 6 WebKit Commit Bot 2016-01-28 01:06:39 PST 
Comment on attachment 270098 [details]
Patch

Clearing flags on attachment: 270098

Committed r195735: <http://trac.webkit.org/changeset/195735>
Comment 7 WebKit Commit Bot 2016-01-28 01:06:42 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Carlos Alberto Lopez Perez 2016-07-06 07:57:14 PDT 
(In reply to comment #6)
> Comment on attachment 270098 [details]
> Patch
> 
> Clearing flags on attachment: 270098
> 
> Committed r195735: <http://trac.webkit.org/changeset/195735>

Seems this has indirectly raised the build dependency for GSTreamer to > 1.1 version, because gst_context_ref() is not available on 1.0.x
Comment 9 Philippe Normand 2016-07-06 08:26:00 PDT 
1.1 ? There is no such version yet.
Comment 10 Philippe Normand 2016-07-06 08:28:10 PDT 
Ok so we need an #ifdef around this.
Comment 11 Carlos Alberto Lopez Perez 2016-07-06 08:47:05 PDT 
(In reply to comment #9)
> 1.1 ? There is no such version yet.

1.1.1 i mean
Comment 12 Carlos Alberto Lopez Perez 2016-07-06 09:01:59 PDT 
(In reply to comment #8)
> (In reply to comment #6)
> > Comment on attachment 270098 [details]
> > Patch
> > 
> > Clearing flags on attachment: 270098
> > 
> > Committed r195735: <http://trac.webkit.org/changeset/195735>
> 
> Seems this has indirectly raised the build dependency for GSTreamer to > 1.1
> version, because gst_context_ref() is not available on 1.0.x

To be fair, r195735 didn't caused this. It seems this was happening since at least r181499, because gst_context_new() is also not available on 1.0.x

?

(In reply to comment #10)
> Ok so we need an #ifdef around this.

Or maybe is better to just raise the gstreamer minimum version on cmake ?