RESOLVED FIXED Bug 153568
B3 IntRange analysis should know more about shifting 
https://bugs.webkit.org/show_bug.cgi?id=153568
Summary B3 IntRange analysis should know more about shifting
Filip Pizlo
Reported 2016-01-27 15:43:34 PST
This will help remove another overflow check in Octane/encrypt.
Attachments
the patch (5.80 KB, patch)
2016-01-27 15:47 PST, Filip Pizlo 		benjamin: review+
benjamin: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2016-01-27 15:47:16 PST
Created attachment 270055 [details] the patch
Benjamin Poulain
Comment 2 2016-01-27 16:55:03 PST
Comment on attachment 270055 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=270055&action=review > Source/JavaScriptCore/b3/B3ReduceStrength.cpp:280 > + return sShr<int32_t>(shiftAmount); int32_t?
Filip Pizlo
Comment 3 2016-01-27 20:23:46 PST
(In reply to comment #2) > Comment on attachment 270055 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=270055&action=review > > > Source/JavaScriptCore/b3/B3ReduceStrength.cpp:280 > > + return sShr<int32_t>(shiftAmount); > > int32_t? That's embarrassing.
Filip Pizlo
Comment 4 2016-01-27 20:24:13 PST
I'll write some tests before landing this.
Filip Pizlo
Comment 5 2016-01-27 21:22:43 PST
Landed in http://trac.webkit.org/changeset/195728
Note You need to log in before you can comment on or make changes to this bug.