Bug 153568 - B3 IntRange analysis should know more about shifting
Summary: B3 IntRange analysis should know more about shifting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 150507
  Show dependency tree / graph
 
Reported: 2016-01-27 15:43 PST by Filip Pizlo
Modified: 2016-01-27 21:22 PST (History)
11 users (show)

See Also:

Attachments
the patch (5.80 KB, patch)
2016-01-27 15:47 PST, Filip Pizlo 		benjamin: review+
benjamin: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-01-27 15:43:34 PST 
This will help remove another overflow check in Octane/encrypt.
Comment 1 Filip Pizlo 2016-01-27 15:47:16 PST 
Created attachment 270055 [details]
the patch
Comment 2 Benjamin Poulain 2016-01-27 16:55:03 PST 
Comment on attachment 270055 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270055&action=review

> Source/JavaScriptCore/b3/B3ReduceStrength.cpp:280
> +            return sShr<int32_t>(shiftAmount);

int32_t?
Comment 3 Filip Pizlo 2016-01-27 20:23:46 PST 
(In reply to comment #2)
> Comment on attachment 270055 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=270055&action=review
> 
> > Source/JavaScriptCore/b3/B3ReduceStrength.cpp:280
> > +            return sShr<int32_t>(shiftAmount);
> 
> int32_t?

That's embarrassing.
Comment 4 Filip Pizlo 2016-01-27 20:24:13 PST 
I'll write some tests before landing this.
Comment 5 Filip Pizlo 2016-01-27 21:22:43 PST 
Landed in http://trac.webkit.org/changeset/195728