Bug 153555 - [FTL][Win64] Compile fix.
Summary: [FTL][Win64] Compile fix.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-27 12:49 PST by peavo
Modified: 2016-01-27 14:10 PST (History)
7 users (show)

See Also:


Attachments
Patch (2.20 KB, patch)
2016-01-27 12:54 PST, peavo
achristensen: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2016-01-27 12:49:09 PST
When compiling FTLOSRExitCompiler.cpp, I get the following error:

FTLOSRExitCompiler.cpp(585): error C2121: '#': invalid character: possibly the result of a macro expansion
FTLOSRExitCompiler.cpp(570): error C2059: syntax error: 'if'

MSVC does not accept preprocessor conditionals in macros, it seems.
Comment 1 peavo 2016-01-27 12:54:14 PST
Created attachment 270026 [details]
Patch
Comment 2 Alex Christensen 2016-01-27 13:10:53 PST
Comment on attachment 270026 [details]
Patch

I'm surprised other compilers accept this.
Comment 3 peavo 2016-01-27 13:29:28 PST
(In reply to comment #2)
> Comment on attachment 270026 [details]
> Patch
> 
> I'm surprised other compilers accept this.

Yes, I am not sure what the standards says about this case. Thanks for reviewing :)
Comment 4 peavo 2016-01-27 14:10:16 PST
Committed r195691: <http://trac.webkit.org/changeset/195691>