Bug 153509 – Generalize ResourceUsageData gathering to be used outside of ResourceUsageOverlay

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
Generalize ResourceUsageData gathering to be used outside of ResourceUsageOverlay.

Inspector wants to show some high level memory information. It could reuse the data, and data gathering, that ResourceUsageOverlay currently does. Rework this so that the ResourceUsageData to be used by inspector can be gathered in a platform independent way. Rename the enable flag now that this will not be specific to an Overlay.

[Radar WebKit Bug Importer]

<rdar://problem/24354291>

[Joseph Pecoraro]

Created attachment 269916 [details]
[PATCH] Proposed Fix

[WebKit Commit Bot]

Attachment 269916 [details] did not pass style-queue:


ERROR: Source/WebCore/page/ResourceUsageThread.h:49:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/ResourceUsageThread.h:68:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/ResourceUsageData.h:63:  The parameter name "data" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/page/ResourceUsageThread.cpp:48:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/page/ResourceUsageThread.cpp:83:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 5 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Andreas Kling]

Comment on attachment 269916 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=269916&action=review

r=me

> Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:173
> +    ASSERT(categories.size = d.categories.size);
> +    for (size_t i = 0; i < categories.size; ++i)

size() vs size
= vs ==

[Andreas Kling]

Comment on attachment 269916 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=269916&action=review

> Source/WebCore/page/scrolling/ScrollingThread.cpp:54
> -        std::lock_guard<Lock> lock(singleton().m_functionsMutex);
> +        std::lock_guard<Lock> lock(scrollingThread.m_functionsMutex);

joe pls

[Joseph Pecoraro]

<http://trac.webkit.org/changeset/195644>