Bug 153497 - [webkitdirs] isCMakeBuild should be true by default
Summary: [webkitdirs] isCMakeBuild should be true by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-26 11:57 PST by Konstantin Tokarev
Modified: 2016-01-26 13:14 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.06 KB, patch)
2016-01-26 11:58 PST, Konstantin Tokarev 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Tokarev 2016-01-26 11:57:37 PST 
Since all ports use CMake or are migrating to it, new ports should be encouraged to use CMake as well. So isCMakeBuild should return true by default.
Comment 1 Konstantin Tokarev 2016-01-26 11:58:20 PST 
Created attachment 269901 [details]
Patch
Comment 2 Michael Catanzaro 2016-01-26 12:59:26 PST 
Comment on attachment 269901 [details]
Patch

It looks like isAppleMacWebKit() returns true for iOS, so I think this is fine.
Comment 3 WebKit Commit Bot 2016-01-26 13:14:41 PST 
Comment on attachment 269901 [details]
Patch

Clearing flags on attachment: 269901

Committed r195613: <http://trac.webkit.org/changeset/195613>
Comment 4 WebKit Commit Bot 2016-01-26 13:14:45 PST 
All reviewed patches have been landed.  Closing bug.