Bug 153496 - [webkitdirs] Removed check for bison, gperf, and flex.
Summary: [webkitdirs] Removed check for bison, gperf, and flex.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-26 11:47 PST by Konstantin Tokarev
Modified: 2016-01-26 13:38 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.50 KB, patch)
2016-01-26 11:48 PST, Konstantin Tokarev 		no flags Details | Formatted Diff | Diff
Patch (1.71 KB, patch)
2016-01-26 13:23 PST, Konstantin Tokarev 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Tokarev 2016-01-26 11:47:00 PST 
bison, gperf, and flex are basic prerequisites of build, and condition already included all ports present in trunk.
Comment 1 Konstantin Tokarev 2016-01-26 11:48:12 PST 
Created attachment 269899 [details]
Patch
Comment 2 Konstantin Tokarev 2016-01-26 11:48:45 PST 
Also removed outdated comment from 2006.
Comment 3 Alex Christensen 2016-01-26 12:57:22 PST 
Comment on attachment 269899 [details]
Patch

I think we could completely remove this check.  They are done in WebKitCommon.cmake, and bison, gperf, and flex don't necessarily need to be in the PATH
Comment 4 Konstantin Tokarev 2016-01-26 13:23:25 PST 
Created attachment 269910 [details]
Patch
Comment 5 WebKit Commit Bot 2016-01-26 13:38:30 PST 
Comment on attachment 269910 [details]
Patch

Clearing flags on attachment: 269910

Committed r195617: <http://trac.webkit.org/changeset/195617>
Comment 6 WebKit Commit Bot 2016-01-26 13:38:33 PST 
All reviewed patches have been landed.  Closing bug.