Bug 153494 - Calling video.controls=true during a scrub operation cancels scrub.
Summary: Calling video.controls=true during a scrub operation cancels scrub.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on: 153513
Blocks:
  Show dependency treegraph
 
Reported: 2016-01-26 11:23 PST by Jer Noble
Modified: 2016-01-27 07:21 PST (History)
3 users (show)

See Also:


Attachments
Patch (5.62 KB, patch)
2016-01-26 11:25 PST, Jer Noble
eric.carlson: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews115 for mac-yosemite (866.02 KB, application/zip)
2016-01-26 12:04 PST, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2016-01-26 11:23:52 PST
Calling video.controls=true during a scrub operation cancels scrub.
Comment 1 Jer Noble 2016-01-26 11:25:38 PST
Created attachment 269894 [details]
Patch
Comment 2 Jer Noble 2016-01-26 11:52:17 PST
<rdar://problem/24290406>
Comment 3 Build Bot 2016-01-26 12:04:32 PST
Comment on attachment 269894 [details]
Patch

Attachment 269894 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/742237

New failing tests:
imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection-1.html
Comment 4 Build Bot 2016-01-26 12:04:35 PST
Created attachment 269903 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 5 Jer Noble 2016-01-26 12:58:43 PST
Committed r195610: <http://trac.webkit.org/changeset/195610>
Comment 6 Ryan Haddad 2016-01-26 14:33:02 PST
The test added with this change seems to be timing out on almost every run:

<http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmedia-controls-drag-timeline-set-controls-property.html>
Comment 7 Ryan Haddad 2016-01-26 17:22:41 PST
Since I reopened this myself and webkitbot didn't leave a comment: 
As an FYI, this was rolled out in <http://trac.webkit.org/changeset/195626>
Comment 8 Jer Noble 2016-01-27 07:21:41 PST
Committed r195671: <http://trac.webkit.org/changeset/195671>