RESOLVED FIXED 153483
kill-old-processes: allow to specify on the environment of the bot a list of process that should be killed. 
https://bugs.webkit.org/show_bug.cgi?id=153483
Summary kill-old-processes: allow to specify on the environment of the bot a list of ...
Carlos Alberto Lopez Perez
Reported 2016-01-26 06:21:50 PST
We are having an issue with the GTK+ bots because of bug 127352 that is causing that thousands of at-spi-bus-launcher and dbus-daemon process remain open. On r166798 I tried to workaround this by killing dbus-daemon on the script kill-old-processes that the bots run before any new build. However this turned out to be problematic for the performance bots so it was reverted on r169343. So, I think we still want to kill dbus-daemon (and maybe at-spi-bus-launcher) also on the test bots but not on the performance bots. An idea to achieve this is to implement on kill-old-processes support for killing any task defined on a given environment variable. This way the admin of each bot can set this variable accordingly
Attachments
Patch (2.22 KB, patch)
2016-01-26 06:30 PST, Carlos Alberto Lopez Perez 		ossy: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Alberto Lopez Perez
Comment 1 2016-01-26 06:30:19 PST
Created attachment 269880 [details] Patch
Csaba Osztrogonác
Comment 2 2016-01-26 07:14:54 PST
Comment on attachment 269880 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=269880&action=review LGTM, let's add this environment variable to be able hack bots easier. > Tools/BuildSlaveSupport/kill-old-processes:111 > + tasksToKill = os.getenv('WEBKITBOT_TASKSTOKILL', "").split() nit: Could you use '' or "" for both parameters to have better looking code?
Carlos Alberto Lopez Perez
Comment 3 2016-01-26 07:48:09 PST
Committed r195587: <http://trac.webkit.org/changeset/195587>
Note You need to log in before you can comment on or make changes to this bug.