Bug 153481 - [GTK][EFL] Rename ScrollAnimationNone as ScrollAnimationSmooth
Summary: [GTK][EFL] Rename ScrollAnimationNone as ScrollAnimationSmooth
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks: 153405
  Show dependency treegraph
 
Reported: 2016-01-26 05:20 PST by Carlos Garcia Campos
Modified: 2016-01-27 02:33 PST (History)
6 users (show)

See Also:


Attachments
Patch (68.36 KB, patch)
2016-01-26 05:34 PST, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff
Fix the build (68.36 KB, patch)
2016-01-26 05:55 PST, Carlos Garcia Campos
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2016-01-26 05:20:49 PST
ScrollAnimationNone has always been used by EFL and GTK port to implement smooth scrolling. I think it should be possible for other scroll animators to implement smooth scrolling or even implement other kind of scroll animations. For example, in the future I would like to have kinetic scrolling implemented for the GTK+ port to match all other GTK+ application and decide at runtime between different animations without having to use a different scroll animator class.
Comment 1 Carlos Garcia Campos 2016-01-26 05:34:28 PST
Created attachment 269877 [details]
Patch

For bug #153230 I plan to add ScrollAnimatorGtk to implement overlay scrollbars and use ScrollAnimationSmooth to still support smooth scrolling without using ScrollAnimatorSmooth.
Comment 2 WebKit Commit Bot 2016-01-26 05:35:47 PST
Attachment 269877 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/ScrollAnimationSmooth.cpp:43:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/ScrollAnimationSmooth.h:46:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/ScrollAnimationSmooth.h:103:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 3 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Carlos Garcia Campos 2016-01-26 05:55:04 PST
Created attachment 269878 [details]
Fix the build
Comment 4 WebKit Commit Bot 2016-01-26 05:56:45 PST
Attachment 269878 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/ScrollAnimationSmooth.cpp:43:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/ScrollAnimationSmooth.h:46:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/ScrollAnimationSmooth.h:103:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 3 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Carlos Garcia Campos 2016-01-27 02:33:17 PST
Committed r195661: <http://trac.webkit.org/changeset/195661>