RESOLVED FIXED 153476
Move some logic related to the default control that changes video presentation mode from mediaControlsiOS.js to mediaControlsApple.js
https://bugs.webkit.org/show_bug.cgi?id=153476
Summary Move some logic related to the default control that changes video presentatio...
Ada Chan
Reported 2016-01-25 23:11:08 PST
Move some logic related to the default control that changes video presentation mode from mediaControlsiOS.js to mediaControlsApple.js. Also, add the necessary styles to support that control in mediaControlsApple.css.
Attachments
Patch (20.60 KB, patch)
2016-01-26 00:36 PST, Ada Chan
no flags
Archive of layout-test-results from ews101 for mac-yosemite (992.79 KB, application/zip)
2016-01-26 01:28 PST, Build Bot
no flags
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (1.01 MB, application/zip)
2016-01-26 01:31 PST, Build Bot
no flags
Archive of layout-test-results from ews116 for mac-yosemite (884.94 KB, application/zip)
2016-01-26 01:33 PST, Build Bot
no flags
Patch (21.67 KB, patch)
2016-01-27 12:29 PST, Ada Chan
eric.carlson: review+
Ada Chan
Comment 1 2016-01-25 23:12:04 PST
Ada Chan
Comment 2 2016-01-26 00:36:54 PST
Build Bot
Comment 3 2016-01-26 01:28:18 PST
Comment on attachment 269862 [details] Patch Attachment 269862 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/740365 New failing tests: media/media-fullscreen-inline.html fullscreen/full-screen-crash-offsetLeft.html fullscreen/full-screen-stacking-context.html fullscreen/video-controls-timeline.html fullscreen/full-screen-no-style-sharing.html fullscreen/full-screen-iframe-legacy.html fullscreen/video-controls-drag.html fast/regions/fullscreen/full-screen-video-from-region.html fullscreen/video-specified-size.html fast/regions/fullscreen/full-screen-video-in-region-crash.html media/video-controls-visible-exiting-fullscreen.html media/video-controls-no-display-with-text-track.html
Build Bot
Comment 4 2016-01-26 01:28:21 PST
Created attachment 269865 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5
Build Bot
Comment 5 2016-01-26 01:31:17 PST
Comment on attachment 269862 [details] Patch Attachment 269862 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/740367 New failing tests: media/media-fullscreen-inline.html fullscreen/full-screen-crash-offsetLeft.html fullscreen/full-screen-stacking-context.html fullscreen/video-controls-timeline.html fullscreen/full-screen-no-style-sharing.html fullscreen/full-screen-iframe-legacy.html fullscreen/video-controls-drag.html fast/regions/fullscreen/full-screen-video-from-region.html fullscreen/video-specified-size.html fast/regions/fullscreen/full-screen-video-in-region-crash.html media/video-controls-visible-exiting-fullscreen.html media/video-controls-no-display-with-text-track.html
Build Bot
Comment 6 2016-01-26 01:31:20 PST
Created attachment 269866 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Build Bot
Comment 7 2016-01-26 01:33:07 PST
Comment on attachment 269862 [details] Patch Attachment 269862 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/740359 New failing tests: media/media-fullscreen-inline.html fullscreen/full-screen-crash-offsetLeft.html fullscreen/full-screen-stacking-context.html fullscreen/video-controls-timeline.html fullscreen/full-screen-no-style-sharing.html fullscreen/video-controls-drag.html fast/regions/fullscreen/full-screen-video-from-region.html fullscreen/video-specified-size.html fast/regions/fullscreen/full-screen-video-in-region-crash.html media/video-controls-visible-exiting-fullscreen.html media/video-controls-no-display-with-text-track.html
Build Bot
Comment 8 2016-01-26 01:33:10 PST
Created attachment 269867 [details] Archive of layout-test-results from ews116 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5
Ada Chan
Comment 9 2016-01-26 11:06:40 PST
Comment on attachment 269862 [details] Patch I'll investigate the failures.
Ada Chan
Comment 10 2016-01-27 11:06:44 PST
Looks like some script in mediaControlsiOS.js that got moved to mediaControlsApple.js can have an infinite recursion if webkitPresentationMode is not supported: presentationMode: function() { if ('webkitPresentationMode' in this.video) return this.video.webkitPresentationMode; if (this.isFullScreen()) return 'fullscreen'; return 'inline'; }, isFullScreen: function() { return this.video.webkitDisplayingFullscreen && this.presentationMode() != 'picture-in-picture'; }, Will fix this issue and send an updated patch.
Ada Chan
Comment 11 2016-01-27 12:29:14 PST
Ada Chan
Comment 12 2016-01-27 14:31:56 PST
Note You need to log in before you can comment on or make changes to this bug.