Move some logic related to the default control that changes video presentation mode from mediaControlsiOS.js to mediaControlsApple.js. Also, add the necessary styles to support that control in mediaControlsApple.css.
<rdar://problem/24171323>
Created attachment 269862 [details] Patch
Comment on attachment 269862 [details] Patch Attachment 269862 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/740365 New failing tests: media/media-fullscreen-inline.html fullscreen/full-screen-crash-offsetLeft.html fullscreen/full-screen-stacking-context.html fullscreen/video-controls-timeline.html fullscreen/full-screen-no-style-sharing.html fullscreen/full-screen-iframe-legacy.html fullscreen/video-controls-drag.html fast/regions/fullscreen/full-screen-video-from-region.html fullscreen/video-specified-size.html fast/regions/fullscreen/full-screen-video-in-region-crash.html media/video-controls-visible-exiting-fullscreen.html media/video-controls-no-display-with-text-track.html
Created attachment 269865 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 269862 [details] Patch Attachment 269862 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/740367 New failing tests: media/media-fullscreen-inline.html fullscreen/full-screen-crash-offsetLeft.html fullscreen/full-screen-stacking-context.html fullscreen/video-controls-timeline.html fullscreen/full-screen-no-style-sharing.html fullscreen/full-screen-iframe-legacy.html fullscreen/video-controls-drag.html fast/regions/fullscreen/full-screen-video-from-region.html fullscreen/video-specified-size.html fast/regions/fullscreen/full-screen-video-in-region-crash.html media/video-controls-visible-exiting-fullscreen.html media/video-controls-no-display-with-text-track.html
Created attachment 269866 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 269862 [details] Patch Attachment 269862 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/740359 New failing tests: media/media-fullscreen-inline.html fullscreen/full-screen-crash-offsetLeft.html fullscreen/full-screen-stacking-context.html fullscreen/video-controls-timeline.html fullscreen/full-screen-no-style-sharing.html fullscreen/video-controls-drag.html fast/regions/fullscreen/full-screen-video-from-region.html fullscreen/video-specified-size.html fast/regions/fullscreen/full-screen-video-in-region-crash.html media/video-controls-visible-exiting-fullscreen.html media/video-controls-no-display-with-text-track.html
Created attachment 269867 [details] Archive of layout-test-results from ews116 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 269862 [details] Patch I'll investigate the failures.
Looks like some script in mediaControlsiOS.js that got moved to mediaControlsApple.js can have an infinite recursion if webkitPresentationMode is not supported: presentationMode: function() { if ('webkitPresentationMode' in this.video) return this.video.webkitPresentationMode; if (this.isFullScreen()) return 'fullscreen'; return 'inline'; }, isFullScreen: function() { return this.video.webkitDisplayingFullscreen && this.presentationMode() != 'picture-in-picture'; }, Will fix this issue and send an updated patch.
Created attachment 270023 [details] Patch
Committed: http://trac.webkit.org/changeset/195693