Bug 153475 - Allow canvas to use display-list drawing for testing
Summary: Allow canvas to use display-list drawing for testing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks: 152808
  Show dependency tree / graph
 
Reported: 2016-01-25 22:36 PST by Simon Fraser (smfr)
Modified: 2016-01-26 17:53 PST (History)
10 users (show)

See Also:

Attachments
Patch (21.22 KB, patch)
2016-01-25 22:42 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (21.65 KB, patch)
2016-01-25 22:45 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-yosemite (668.43 KB, application/zip)
2016-01-25 23:12 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews115 for mac-yosemite (278.30 KB, application/zip)
2016-01-25 23:22 PST, Build Bot 		no flags Details
Patch (21.60 KB, patch)
2016-01-25 23:24 PST, Simon Fraser (smfr) 		dino: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2016-01-25 22:36:58 PST 
Allow canvas to use display-list drawing for testing
Comment 1 Simon Fraser (smfr) 2016-01-25 22:42:36 PST 
Created attachment 269850 [details]
Patch
Comment 2 Simon Fraser (smfr) 2016-01-25 22:45:34 PST 
Created attachment 269852 [details]
Patch
Comment 3 Build Bot 2016-01-25 23:12:09 PST 
Comment on attachment 269852 [details]
Patch

Attachment 269852 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/739998

Number of test failures exceeded the failure limit.
Comment 4 Build Bot 2016-01-25 23:12:13 PST 
Created attachment 269854 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 5 Build Bot 2016-01-25 23:22:46 PST 
Comment on attachment 269852 [details]
Patch

Attachment 269852 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/740025

Number of test failures exceeded the failure limit.
Comment 6 Build Bot 2016-01-25 23:22:50 PST 
Created attachment 269855 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 7 Simon Fraser (smfr) 2016-01-25 23:24:23 PST 
Created attachment 269857 [details]
Patch
Comment 8 Dean Jackson 2016-01-26 17:42:39 PST 
Comment on attachment 269857 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=269857&action=review

> Source/WebCore/html/canvas/CanvasRenderingContext2D.h:60
> +namespace DisplayList {
> +typedef unsigned AsTextFlags;
> +}

I don't think you need this. CRC2D includes CRC, which includes HTMLCanvasElement, and you put this typedef there already.

> LayoutTests/displaylists/canvas-display-list-expected.txt:2
> +(

This is never closed.
Comment 9 Simon Fraser (smfr) 2016-01-26 17:53:40 PST 
https://trac.webkit.org/r195646