Bug 153469 - Fix internal Windows build
Summary: Fix internal Windows build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-01-25 17:15 PST by Alex Christensen
Modified: 2016-01-26 15:19 PST (History)
2 users (show)

See Also:


Attachments
Patch (11.49 KB, patch)
2016-01-25 17:15 PST, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (11.67 KB, patch)
2016-01-25 17:20 PST, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (12.10 KB, patch)
2016-01-25 17:57 PST, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (12.46 KB, patch)
2016-01-25 18:23 PST, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-01-25 17:15:45 PST
Fix internal Windows build
Comment 1 Alex Christensen 2016-01-25 17:15:59 PST
Created attachment 269821 [details]
Patch
Comment 2 WebKit Commit Bot 2016-01-25 17:18:13 PST
Attachment 269821 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alex Christensen 2016-01-25 17:20:53 PST
Created attachment 269823 [details]
Patch
Comment 4 Brent Fulgham 2016-01-25 17:24:57 PST
Comment on attachment 269823 [details]
Patch

r=me!
Comment 5 Alex Christensen 2016-01-25 17:57:05 PST
Created attachment 269830 [details]
Patch
Comment 6 Alex Christensen 2016-01-25 18:23:20 PST
Created attachment 269834 [details]
Patch
Comment 7 WebKit Commit Bot 2016-01-25 22:12:59 PST
Comment on attachment 269834 [details]
Patch

Clearing flags on attachment: 269834

Committed r195582: <http://trac.webkit.org/changeset/195582>
Comment 8 WebKit Commit Bot 2016-01-25 22:13:03 PST
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2016-01-26 15:19:24 PST
<rdar://problem/24356482>