Revision r194840 <http://trac.webkit.org/194840> implemented a Sampling profiler in JSC for the Inspector UI.
This feature is not enabled in the GTK+ port.
There are some layout tests regarding this feature that are timing out on the GTK+ bots.
I'm going to mark such tests as skipped on the GTK+ port.
I'm also opening this bug for anyone interested in enabling and testing this feature on the GTK+ port.
Skipped inspector/sampling-profiler tests on https://trac.webkit.org/r195573
Is there someone who might be interested in trying ENABLE(SAMPLING_PROFILER) on Linux ports?
(In reply to comment #2)
> Is there someone who might be interested in trying ENABLE(SAMPLING_PROFILER)
> on Linux ports?
I have just tested this patch on top of r195735:
@@ -799,7 +799,7 @@
/* The SamplingProfiler is the probabilistic and low-overhead profiler used by
-#if (OS(DARWIN) || OS(WINDOWS)) && ENABLE(JIT)
+#if (OS(DARWIN) || OS(LINUX) || OS(WINDOWS)) && ENABLE(JIT)
#define ENABLE_SAMPLING_PROFILER 1
#define ENABLE_SAMPLING_PROFILER 0
And tried to build the GTK+ port (release). I got this build error:
#error Need a way to get the frame pointer for another thread on this platform
#error Need a way to get the instruction pointer for another thread on this platform
2 errors generated.
Looking at where it fails, it looks this tries to do some OS/arch-specific low-level stuff with the instruction pointers that I'm afraid I won't have the time and expertise required to fix.
If somebody else is willing to take this, feel free.
I spoke to Yusuke last night on IRC
and he said he'd be willing to help
implement these few functions to make
the sampling profiler work on other
platforms. The only functions that need
to be implemented for it to work are the
ones behind ENABLE(SAMPLING_PROFILER)
guard in heap/MachineStackMarker
See also: https://lists.webkit.org/pipermail/webkit-dev/2016-January/027888.html
see this patch:
*** This bug has been marked as a duplicate of bug 153638 ***