Bug 153465 - [iOS] Documents without an explicit width should not get fast tapping
Summary: [iOS] Documents without an explicit width should not get fast tapping
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-25 16:39 PST by Dean Jackson
Modified: 2016-01-26 12:10 PST (History)
6 users (show)

See Also:

Attachments
Patch (12.21 KB, patch)
2016-01-25 17:01 PST, Dean Jackson 		no flags Details | Formatted Diff | Diff
Patch (12.98 KB, patch)
2016-01-26 03:12 PST, Dean Jackson 		no flags Details | Formatted Diff | Diff
Patch (39.77 KB, patch)
2016-01-26 12:00 PST, Dean Jackson 		simon.fraser: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2016-01-25 16:39:20 PST 
[iOS] Documents without an explicit width should not get fast tapping
Comment 1 Dean Jackson 2016-01-25 17:01:33 PST 
Created attachment 269818 [details]
Patch
Comment 2 Simon Fraser (smfr) 2016-01-25 17:23:53 PST 
Comment on attachment 269818 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=269818&action=review

> Source/WebCore/dom/ViewportArguments.cpp:310
> +static bool findSizeValue(const String& keyString, const String& valueString, Document* document, float& sizeValue)

I think I have a minor preference to return the float, and have the bool& as a param.
Comment 3 Wenson Hsieh 2016-01-25 17:25:46 PST 
Comment on attachment 269818 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=269818&action=review

> Source/WebCore/ChangeLog:14
> +        width was explicit. However, it turns out that those ImageDocuments

I found this bit to be somewhat confusing, since an ImageDocument's viewport is explicitly set, but the flag would ship across to the UI process as false. Maybe it would be wise to send over an IsImageDocument flag as well, or just leave a comment where the flag is defined that explains this nuance.
Comment 4 Dean Jackson 2016-01-26 03:12:04 PST 
Created attachment 269875 [details]
Patch
Comment 5 Wenson Hsieh 2016-01-26 06:48:32 PST 
Comment on attachment 269875 [details]
Patch

r=me!
Comment 6 Simon Fraser (smfr) 2016-01-26 11:02:02 PST 
Comment on attachment 269875 [details]
Patch

Please make a test case.
Comment 7 Dean Jackson 2016-01-26 12:00:47 PST 
Created attachment 269902 [details]
Patch
Comment 8 Wenson Hsieh 2016-01-26 12:02:35 PST 
Comment on attachment 269902 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=269902&action=review

> LayoutTests/fast/events/ios/viewport-no-width-value-allows-double-tap.html:10
> +            uiController.doubleTapAtPoint(15, 400, function() {});

The uiScriptComplete should be inside the completion callback to doubleTapAtPoint.
Comment 9 Dean Jackson 2016-01-26 12:10:23 PST 
Committed r195607: <http://trac.webkit.org/changeset/195607>