Bug 153465 – [iOS] Documents without an explicit width should not get fast tapping

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dean Jackson]

[iOS] Documents without an explicit width should not get fast tapping

[Dean Jackson]

Created attachment 269818 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 269818 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=269818&action=review

> Source/WebCore/dom/ViewportArguments.cpp:310
> +static bool findSizeValue(const String& keyString, const String& valueString, Document* document, float& sizeValue)

I think I have a minor preference to return the float, and have the bool& as a param.

[Wenson Hsieh]

Comment on attachment 269818 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=269818&action=review

> Source/WebCore/ChangeLog:14
> +        width was explicit. However, it turns out that those ImageDocuments

I found this bit to be somewhat confusing, since an ImageDocument's viewport is explicitly set, but the flag would ship across to the UI process as false. Maybe it would be wise to send over an IsImageDocument flag as well, or just leave a comment where the flag is defined that explains this nuance.

[Dean Jackson]

Created attachment 269875 [details]
Patch

[Wenson Hsieh]

Comment on attachment 269875 [details]
Patch

r=me!

[Simon Fraser (smfr)]

Comment on attachment 269875 [details]
Patch

Please make a test case.

[Dean Jackson]

Created attachment 269902 [details]
Patch

[Wenson Hsieh]

Comment on attachment 269902 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=269902&action=review

> LayoutTests/fast/events/ios/viewport-no-width-value-allows-double-tap.html:10
> +            uiController.doubleTapAtPoint(15, 400, function() {});

The uiScriptComplete should be inside the completion callback to doubleTapAtPoint.

[Dean Jackson]

Committed r195607: <http://trac.webkit.org/changeset/195607>