Without that, anything that triggers the use of YarrJIT on mips would crash.
Created attachment 269808 [details]
MIPS: define the list of callee saved registers
Created attachment 269809 [details]
After http://trac.webkit.org/changeset/195182 we don't need to use s0 for cmpTempRegister, so it does not need to be saved here.
Created attachment 269928 [details]
New patch that does not save cmpTempRegister
Is this change really necessary? AFAIK, there is no need to have such a prologue/epilogue in YarrJIT.
Created attachment 269955 [details]
New patch using pushPair/popPair
(In reply to comment #5)
> Is this change really necessary? AFAIK, there is no need to have such a
> prologue/epilogue in YarrJIT.
Indeed, I am starting to doubt it myself. It seems that o32 only requires a function to create a callframe if it saves stuff on the stack or calls another function. YarrJIT does not seem to call any function, and since it doesn't use any callee-saved register, I think we don't need to create a stack frame here (i.e. we don't need this patch).
Closing bug to cleanup
Comment on attachment 269955 [details]
Removing review flag as per comments.