RESOLVED INVALID 153457
[mips] YarrJIT: implement generateEnter() and generateReturn() 
https://bugs.webkit.org/show_bug.cgi?id=153457
Summary [mips] YarrJIT: implement generateEnter() and generateReturn()
Guillaume Emont
Reported 2016-01-25 15:36:44 PST
Without that, anything that triggers the use of YarrJIT on mips would crash.
Attachments
MIPS: define the list of callee saved registers (2.53 KB, patch)
2016-01-25 15:39 PST, Guillaume Emont 		no flags
DetailsFormatted DiffDiff
Patch (2.53 KB, patch)
2016-01-25 15:48 PST, Guillaume Emont 		no flags
DetailsFormatted DiffDiff
Patch (2.20 KB, patch)
2016-01-26 14:41 PST, Guillaume Emont 		no flags
DetailsFormatted DiffDiff
Patch (1.89 KB, patch)
2016-01-26 17:12 PST, Guillaume Emont 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Guillaume Emont
Comment 1 2016-01-25 15:39:36 PST
Created attachment 269808 [details] MIPS: define the list of callee saved registers
Guillaume Emont
Comment 2 2016-01-25 15:48:03 PST
Created attachment 269809 [details] Patch
Konstantin Tokarev
Comment 3 2016-01-25 23:49:51 PST
After http://trac.webkit.org/changeset/195182 we don't need to use s0 for cmpTempRegister, so it does not need to be saved here.
Guillaume Emont
Comment 4 2016-01-26 14:41:08 PST
Created attachment 269928 [details] Patch New patch that does not save cmpTempRegister
Julien Brianceau
Comment 5 2016-01-26 15:58:13 PST
Is this change really necessary? AFAIK, there is no need to have such a prologue/epilogue in YarrJIT.
Guillaume Emont
Comment 6 2016-01-26 17:12:55 PST
Created attachment 269955 [details] Patch New patch using pushPair/popPair
Guillaume Emont
Comment 7 2016-02-09 17:02:23 PST
(In reply to comment #5) > Is this change really necessary? AFAIK, there is no need to have such a > prologue/epilogue in YarrJIT. Indeed, I am starting to doubt it myself. It seems that o32 only requires a function to create a callframe if it saves stuff on the stack or calls another function. YarrJIT does not seem to call any function, and since it doesn't use any callee-saved register, I think we don't need to create a stack frame here (i.e. we don't need this patch).
Julien Brianceau
Comment 8 2016-06-02 05:49:22 PDT
Closing bug to cleanup
Michael Catanzaro
Comment 9 2016-07-14 05:32:02 PDT
Comment on attachment 269955 [details] Patch Removing review flag as per comments.
Note You need to log in before you can comment on or make changes to this bug.