Bug 153447 - Web Inspector: Have top-level ScriptTimelineDataGridNode events show sample counts
Summary: Web Inspector: Have top-level ScriptTimelineDataGridNode events show sample c...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Saam Barati
Keywords: InRadar
Depends on:
Reported: 2016-01-25 14:24 PST by Saam Barati
Modified: 2016-01-25 16:26 PST (History)
8 users (show)

See Also:

patch (2.88 KB, patch)
2016-01-25 15:15 PST, Saam Barati
joepeck: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2016-01-25 14:24:51 PST
Comment 1 Radar WebKit Bug Importer 2016-01-25 14:25:25 PST
Comment 2 Timothy Hatcher 2016-01-25 14:33:40 PST
Comment 3 Saam Barati 2016-01-25 15:15:20 PST
Created attachment 269801 [details]
Comment 4 Joseph Pecoraro 2016-01-25 15:26:20 PST
Comment on attachment 269801 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=269801&action=review

r=me handling backwards combat

> Source/WebInspectorUI/UserInterface/Models/ScriptTimelineRecord.js:65
> +    get callCount()
> +    {
> +        return this._callCount;
> +    }

We should only do this when we are using the sampling profiler. Otherwise when it actually says "Call Count" instead of "Samples" we will see some # for "Script Evaluated" which doesn't make sense.

You could make this:

    get callCount()
        // COMPATIBILITY(iOS 9): Before the ScriptProfilerAgent we did not have sample data. Return NaN to match old behavior.
        if (!window.ScriptProfilerAgent)
            return NaN;

        // NOTE: callCount here is actually the number of samples.
        return this._callCount;
Comment 5 Saam Barati 2016-01-25 16:26:04 PST
landed in: