Bug 153447 – Web Inspector: Have top-level ScriptTimelineDataGridNode events show sample counts

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Saam Barati]

...

[Radar WebKit Bug Importer]

<rdar://problem/24334137>

[Timothy Hatcher]

<rdar://problem/24329305>

[Saam Barati]

Created attachment 269801 [details]
patch

[Joseph Pecoraro]

Comment on attachment 269801 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=269801&action=review

r=me handling backwards combat

> Source/WebInspectorUI/UserInterface/Models/ScriptTimelineRecord.js:65
> +    get callCount()
> +    {
> +        return this._callCount;
> +    }

We should only do this when we are using the sampling profiler. Otherwise when it actually says "Call Count" instead of "Samples" we will see some # for "Script Evaluated" which doesn't make sense.

You could make this:

    get callCount()
    {
        // COMPATIBILITY(iOS 9): Before the ScriptProfilerAgent we did not have sample data. Return NaN to match old behavior.
        if (!window.ScriptProfilerAgent)
            return NaN;

        // NOTE: callCount here is actually the number of samples.
        return this._callCount;
    }

[Saam Barati]

landed in:
http://trac.webkit.org/changeset/195566