Bug 153427 - Modern IDB: Key generator support for SQLite backend
Summary: Modern IDB: Key generator support for SQLite backend
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 149117 153021
  Show dependency treegraph
 
Reported: 2016-01-25 10:16 PST by Brady Eidson
Modified: 2016-01-26 18:26 PST (History)
4 users (show)

See Also:


Attachments
Patch v1 (12.78 KB, patch)
2016-01-26 17:07 PST, Brady Eidson
no flags Details | Formatted Diff | Diff
Patch for landing (12.56 KB, patch)
2016-01-26 17:19 PST, Brady Eidson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2016-01-25 10:16:32 PST
Modern IDB: Key generator support for SQLite backend
Comment 1 Brady Eidson 2016-01-26 17:07:56 PST
Created attachment 269954 [details]
Patch v1
Comment 2 Brady Eidson 2016-01-26 17:19:44 PST
Created attachment 269956 [details]
Patch for landing
Comment 3 Alex Christensen 2016-01-26 17:25:47 PST
Comment on attachment 269954 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=269954&action=review

> Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:1244
> +    if (static_cast<uint64_t>(currentValue) > maxGeneratorValue)

static_cast not necessary.
Comment 4 WebKit Commit Bot 2016-01-26 18:26:07 PST
Comment on attachment 269956 [details]
Patch for landing

Clearing flags on attachment: 269956

Committed r195648: <http://trac.webkit.org/changeset/195648>
Comment 5 WebKit Commit Bot 2016-01-26 18:26:10 PST
All reviewed patches have been landed.  Closing bug.