Bug 153425 - Modern IDB: Implement getIndexRecord in the SQLite backing store
Summary: Modern IDB: Implement getIndexRecord in the SQLite backing store
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 149117 153021
  Show dependency treegraph
 
Reported: 2016-01-25 09:17 PST by Brady Eidson
Modified: 2016-01-25 10:20 PST (History)
4 users (show)

See Also:


Attachments
Patch v1 (8.39 KB, patch)
2016-01-25 09:19 PST, Brady Eidson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2016-01-25 09:17:44 PST
Modern IDB: Implement getIndexRecord in the SQLite backing store
Comment 1 Brady Eidson 2016-01-25 09:19:40 PST
Created attachment 269754 [details]
Patch v1
Comment 2 Darin Adler 2016-01-25 09:29:29 PST
Comment on attachment 269754 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=269754&action=review

> Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:1150
> +        getResult = { SharedBuffer::create(cursor->currentValueBuffer().data(), cursor->currentValueBuffer().size()) };

Is there a way to do this without copying? SharedBuffer knows how to adopt a Vector<char> but not a Vector<uint8_t>. Might be a topic worth returning to.
Comment 3 Brady Eidson 2016-01-25 09:57:47 PST
(In reply to comment #2)
> Comment on attachment 269754 [details]
> Patch v1
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=269754&action=review
> 
> > Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:1150
> > +        getResult = { SharedBuffer::create(cursor->currentValueBuffer().data(), cursor->currentValueBuffer().size()) };
> 
> Is there a way to do this without copying? SharedBuffer knows how to adopt a
> Vector<char> but not a Vector<uint8_t>. Might be a topic worth returning to.

Definitely plan on returning to this.

Right now I'm trying to shovel over the WebKit2 SQLite backend with minimal changes, but I definitely plan to give it a once over afterwards.

Thanks!
Comment 4 WebKit Commit Bot 2016-01-25 10:20:32 PST
Comment on attachment 269754 [details]
Patch v1

Clearing flags on attachment: 269754

Committed r195541: <http://trac.webkit.org/changeset/195541>
Comment 5 WebKit Commit Bot 2016-01-25 10:20:35 PST
All reviewed patches have been landed.  Closing bug.