Bug 153418 - Modern IDB: Some IDB tests crash in ~SQLiteIDBBackingStore
Summary: Modern IDB: Some IDB tests crash in ~SQLiteIDBBackingStore
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 149117 153021
  Show dependency treegraph
Reported: 2016-01-24 22:34 PST by Brady Eidson
Modified: 2016-01-25 08:47 PST (History)
2 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2016-01-24 22:34:42 PST
Modern IDB: Some IDB tests crash in ~SQLiteIDBBackingStore


Haven't seen these locally, but the crash logs all suggest the same thing: Crash tearing down the JSGlobalObject in the backing store constructor.

The JSGlobalObject almost certainly needs to be cleared out before the VM, instead of vice versa.
Comment 1 Brady Eidson 2016-01-24 22:35:32 PST
Cannot get to this in a timely manner tonight with only my laptop and the sad state my build is in.

Will get to it first thing in the morning.
Comment 2 Brady Eidson 2016-01-24 22:56:55 PST
This was almost certainly introduced along with the VM in http://trac.webkit.org/changeset/195517

I'll land a speculative fix before going to bed.
Comment 3 Brady Eidson 2016-01-24 23:05:01 PST
Unreviewed speculative fix landed in http://trac.webkit.org/changeset/195525

Will check the bots in the A.M.
Comment 4 Brady Eidson 2016-01-25 08:47:54 PST
At least one test was reliably crashing before the speculative fix, and it hasn't happened since.