Bug 153415 - Modern IDB: Implement deleteIndex and getCount for the SQLite backing store
Summary: Modern IDB: Implement deleteIndex and getCount for the SQLite backing store
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 149117 153021
  Show dependency treegraph
 
Reported: 2016-01-24 19:28 PST by Brady Eidson
Modified: 2016-01-25 08:48 PST (History)
4 users (show)

See Also:


Attachments
Patch v1 (31.13 KB, patch)
2016-01-24 20:18 PST, Brady Eidson
darin: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews116 for mac-yosemite (782.79 KB, application/zip)
2016-01-24 21:27 PST, Build Bot
no flags Details
Patch for landing (30.98 KB, patch)
2016-01-24 22:25 PST, Brady Eidson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2016-01-24 19:28:57 PST
Modern IDB: Implement deleteIndex and getCount for the SQLite backing store
Comment 1 Brady Eidson 2016-01-24 20:18:29 PST
Created attachment 269720 [details]
Patch v1
Comment 2 Darin Adler 2016-01-24 21:14:08 PST
Comment on attachment 269720 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=269720&action=review

> Source/WebCore/Modules/indexeddb/server/SQLiteIDBCursor.cpp:88
> +    if (!m_indexID)
> +        m_indexID = IDBIndexMetadata::InvalidId;

Could do this with ? : in the initializer.

    , m_indexID(m_indexID ? m_indexID : IDBIndexMetadata::InvalidId)
Comment 3 Build Bot 2016-01-24 21:27:47 PST
Comment on attachment 269720 [details]
Patch v1

Attachment 269720 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/735392

New failing tests:
imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection.html
Comment 4 Build Bot 2016-01-24 21:27:49 PST
Created attachment 269722 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 5 Brady Eidson 2016-01-24 21:48:29 PST
(In reply to comment #3)
> Comment on attachment 269720 [details]
> Patch v1
> 
> Attachment 269720 [details] did not pass mac-debug-ews (mac):
> Output: http://webkit-queues.webkit.org/results/735392
> 
> New failing tests:
> imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-
> collection.html

Just knowing a test named this failed, it's unclear how this patch caused it.

Looking into it...
Comment 6 Brady Eidson 2016-01-24 22:25:58 PST
Created attachment 269725 [details]
Patch for landing

Perhaps EWS hiccuped or something...?

Made the change Darin suggested and re-uploading for CQ. Running tests locally and will let EWS run as well.
Comment 7 Brady Eidson 2016-01-24 22:28:01 PST
The test that crashed was doing some JSGlobalObject task on a worker thread, but all of the IndexedDB tests that use workers are currently disabled.

I don't see how this was at fault.
Comment 8 Brady Eidson 2016-01-24 22:54:46 PST
Definitely did not see this locally over two full test runs.
Comment 9 WebKit Commit Bot 2016-01-24 23:55:27 PST
Comment on attachment 269725 [details]
Patch for landing

Clearing flags on attachment: 269725

Committed r195527: <http://trac.webkit.org/changeset/195527>