WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
153410
Modern IDB: Support IDBObjectStore.createIndex in the SQLite backing store
https://bugs.webkit.org/show_bug.cgi?id=153410
Summary
Modern IDB: Support IDBObjectStore.createIndex in the SQLite backing store
Brady Eidson
Reported
2016-01-24 12:28:35 PST
Modern IDB: Support IDBObjectStore.createIndex in the SQLite backing store
Attachments
Patch v1
(22.21 KB, patch)
2016-01-24 12:32 PST
,
Brady Eidson
darin
: review+
Details
Formatted Diff
Diff
Patch for landing
(22.66 KB, patch)
2016-01-24 14:53 PST
,
Brady Eidson
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Brady Eidson
Comment 1
2016-01-24 12:32:24 PST
Created
attachment 269703
[details]
Patch v1
Darin Adler
Comment 2
2016-01-24 14:16:15 PST
Comment on
attachment 269703
[details]
Patch v1 View in context:
https://bugs.webkit.org/attachment.cgi?id=269703&action=review
> Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:737 > + ASSERT(m_vm);
Not sure this assertion is valuable given that the code to create m_vm is just above.
> Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:742 > + const IDBKeyData& key = cursor->currentKey();
auto&?
> Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:743 > + const Vector<uint8_t>& valueBuffer = cursor->currentValueBuffer();
auto&?
> Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:745 > + Deprecated::ScriptValue value = deserializeIDBValueBuffer(m_globalObject->globalExec(), Vector<uint8_t>(valueBuffer), true);
auto?
> Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:835 > + } > + {
I think there should be a blank line between these two.
> Source/WebCore/Modules/indexeddb/server/SQLiteIDBCursor.cpp:56 > + auto cursor = std::unique_ptr<SQLiteIDBCursor>(new SQLiteIDBCursor(transaction, objectStoreIdentifier));
Can this use make_unique instead? Problem with private? Long term we would love to just be able to "grep for new without adopt" and it’s not so easy with unique_ptr used like this.
> Source/WebCore/Modules/indexeddb/server/SQLiteIDBCursor.cpp:82 > + , m_indexID(IDBIndexMetadata::InvalidId)
Could we initialize this in the class definition?
> Source/WebCore/Modules/indexeddb/server/SQLiteIDBCursor.cpp:83 > + , m_cursorDirection(IndexedDB::CursorDirection::Next)
Could we initialize this in the class definition?
Brady Eidson
Comment 3
2016-01-24 14:53:23 PST
Created
attachment 269704
[details]
Patch for landing
WebKit Commit Bot
Comment 4
2016-01-24 15:42:21 PST
Comment on
attachment 269704
[details]
Patch for landing Clearing flags on attachment: 269704 Committed
r195517
: <
http://trac.webkit.org/changeset/195517
>
WebKit Commit Bot
Comment 5
2016-01-24 15:42:24 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug