Bug 153403 – [Font Loading] General cleanup

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

[Font Loading] General cleanup

[Myles C. Maxfield]

Created attachment 269682 [details]
Patch

[Myles C. Maxfield]

Created attachment 269686 [details]
Patch

[Myles C. Maxfield]

Created attachment 269687 [details]
Patch

[Myles C. Maxfield]

Created attachment 269688 [details]
Patch

[Build Bot]

Comment on attachment 269688 [details]
Patch

Attachment 269688 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/732296

New failing tests:
fast/invalid/invalidSVGFont.html

[Build Bot]

Created attachment 269689 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 269688 [details]
Patch

Attachment 269688 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/732288

New failing tests:
fast/invalid/invalidSVGFont.html

[Build Bot]

Created attachment 269690 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 269688 [details]
Patch

Attachment 269688 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/732363

New failing tests:
fast/invalid/invalidSVGFont.html

[Build Bot]

Created attachment 269691 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Myles C. Maxfield]

Created attachment 269699 [details]
Patch

[Darin Adler]

Comment on attachment 269688 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=269688&action=review

> Source/WebCore/ChangeLog:18
> +        No new tests because there is no behavior change.

Looks like the invalidSVGFont.html test is crashing with this change.

> Source/WebCore/css/CSSFontFaceSource.h:71
> +    bool isSVGFontFaceSource() const { return m_svgFontFaceElement || is<CachedSVGFont>(m_font.get()); }

Does this have to be inline? Too bad that we have to include CachedSVGFont.h in this header just so we can compile this inline function.

> Source/WebCore/platform/network/HTTPParsers.cpp:129
> +    auto valueStringView = StringView(value);
> +    for (UChar c : valueStringView.codeUnits()) {

Really irritating that you need the local variable here. C++ for loop lifetime rules are failing us!

[Darin Adler]

Comment on attachment 269699 [details]
Patch

r=me assuming this version fixes the crash

[Myles C. Maxfield]

Committed r195523: <http://trac.webkit.org/changeset/195523>