Bug 153395 - Web Inspector: Highlight timeline range handles on hover
Summary: Web Inspector: Highlight timeline range handles on hover
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-01-22 21:47 PST by Nikita Vasilyev
Modified: 2016-01-24 16:59 PST (History)
8 users (show)

See Also:

Attachments
[Animated GIF] Current behavior (354.20 KB, image/gif)
2016-01-22 21:47 PST, Nikita Vasilyev 		no flags Details
[Animated GIF] With the patch applied (468.96 KB, image/gif)
2016-01-22 21:59 PST, Nikita Vasilyev 		no flags Details
Patch (1.75 KB, patch)
2016-01-22 22:06 PST, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
Patch (1.72 KB, patch)
2016-01-23 23:42 PST, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
Patch (1.75 KB, patch)
2016-01-23 23:47 PST, Nikita Vasilyev 		timothy: review+
Details | Formatted Diff | Diff
[Animated GIF] With the patch applied (175.42 KB, image/gif)
2016-01-23 23:51 PST, Nikita Vasilyev 		no flags Details
Patch (1.75 KB, patch)
2016-01-24 15:59 PST, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2016-01-22 21:47:07 PST 
Created attachment 269647 [details]
[Animated GIF] Current behavior

See the attached animated GIF.

When clicking on a timeline range handler that is too close to the edge,
it isn't clear what is going to be resized, the sidebar or the timeline
range selector.

To mitigate the issue, we should highlight range handles on hover.
Comment 1 Radar WebKit Bug Importer 2016-01-22 21:47:21 PST 
<rdar://problem/24312364>
Comment 2 Nikita Vasilyev 2016-01-22 21:59:37 PST 
Created attachment 269651 [details]
[Animated GIF] With the patch applied
Comment 3 Timothy Hatcher 2016-01-22 22:03:08 PST 
Cool! No patch is attached.

I am not sure I expected blue for the state. A darker grey would better match tics controls on the system.
Comment 4 Nikita Vasilyev 2016-01-22 22:06:10 PST 
Created attachment 269652 [details]
Patch
Comment 5 Nikita Vasilyev 2016-01-22 22:45:17 PST 
(In reply to comment #3)
> Cool! No patch is attached.

Attached three minutes after your comment :)

> I am not sure I expected blue for the state. A darker grey would better
> match tics controls on the system.

I'm fine with dark grey. Any tics controls I should look at?
I couldn't recall similar UI anywhere on OS X.
Comment 6 Timothy Hatcher 2016-01-23 08:37:28 PST 
Things like the tab close buttons in Inspector and Safari.
Comment 7 Nikita Vasilyev 2016-01-23 23:42:09 PST 
Created attachment 269683 [details]
Patch
Comment 8 Nikita Vasilyev 2016-01-23 23:47:42 PST 
Created attachment 269684 [details]
Patch
Comment 9 Nikita Vasilyev 2016-01-23 23:51:33 PST 
Created attachment 269685 [details]
[Animated GIF] With the patch applied
Comment 10 Timothy Hatcher 2016-01-24 11:26:17 PST 
Comment on attachment 269684 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=269684&action=review

> Source/WebInspectorUI/UserInterface/Views/TimelineRuler.css:192
> +    background-color: hsl(212, 0%, 50%);

Why not 0 for hue?
Comment 11 Nikita Vasilyev 2016-01-24 15:59:42 PST 
Created attachment 269705 [details]
Patch
Comment 12 WebKit Commit Bot 2016-01-24 16:59:08 PST 
Comment on attachment 269705 [details]
Patch

Clearing flags on attachment: 269705

Committed r195519: <http://trac.webkit.org/changeset/195519>
Comment 13 WebKit Commit Bot 2016-01-24 16:59:12 PST 
All reviewed patches have been landed.  Closing bug.