Bug 153386 - B3 should strength-reduce division by a constant
Summary: B3 should strength-reduce division by a constant
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 150507
  Show dependency treegraph
 
Reported: 2016-01-22 17:54 PST by Filip Pizlo
Modified: 2016-01-22 19:40 PST (History)
11 users (show)

See Also:


Attachments
the patch (17.85 KB, patch)
2016-01-22 17:59 PST, Filip Pizlo
benjamin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-01-22 17:54:39 PST
Patch forthcoming.
Comment 1 Filip Pizlo 2016-01-22 17:59:03 PST
Created attachment 269627 [details]
the patch
Comment 2 WebKit Commit Bot 2016-01-22 18:00:16 PST
Attachment 269627 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h:125:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h:126:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h:127:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h:128:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h:129:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h:130:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h:133:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h:134:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h:135:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h:135:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h:139:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h:140:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h:141:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h:141:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h:141:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h:146:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h:150:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h:151:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 18 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Filip Pizlo 2016-01-22 19:40:32 PST
Landed in http://trac.webkit.org/changeset/195503