Bug 153384 - Use Symbol.species in the builtin TypedArray.prototype functions
Summary: Use Symbol.species in the builtin TypedArray.prototype functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-22 17:23 PST by Keith Miller
Modified: 2016-02-22 12:07 PST (History)
4 users (show)

See Also:

Attachments
Patch (26.01 KB, patch)
2016-01-22 17:36 PST, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch (28.06 KB, patch)
2016-02-19 12:05 PST, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch (28.46 KB, patch)
2016-02-19 12:08 PST, Keith Miller 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews114 for mac-yosemite (544.68 KB, application/zip)
2016-02-19 12:50 PST, Build Bot 		no flags Details
Patch (28.08 KB, patch)
2016-02-19 13:20 PST, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch (28.08 KB, patch)
2016-02-22 11:07 PST, Keith Miller 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2016-01-22 17:23:43 PST 
Use Symbol.species in the builtin TypedArray.prototype functions
Comment 1 Keith Miller 2016-01-22 17:36:33 PST 
Created attachment 269626 [details]
Patch
Comment 2 Keith Miller 2016-01-25 15:54:50 PST 
I think this patch is actually not quite right since the constructors are not supposed to be called.
Comment 3 Geoffrey Garen 2016-02-04 10:53:47 PST 
Comment on attachment 269626 [details]
Patch

r- based on Keith's last comment.
Comment 4 Keith Miller 2016-02-19 12:05:16 PST 
Created attachment 271772 [details]
Patch
Comment 5 Keith Miller 2016-02-19 12:08:32 PST 
Created attachment 271773 [details]
Patch
Comment 6 Keith Miller 2016-02-19 12:10:01 PST 
I have updated this patch with the correct version of the ES6 spec.
Comment 7 Build Bot 2016-02-19 12:50:56 PST 
Comment on attachment 271773 [details]
Patch

Attachment 271773 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/855659

Number of test failures exceeded the failure limit.
Comment 8 Build Bot 2016-02-19 12:50:58 PST 
Created attachment 271787 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 9 Keith Miller 2016-02-19 13:20:32 PST 
Created attachment 271793 [details]
Patch
Comment 10 Keith Miller 2016-02-22 11:07:12 PST 
Created attachment 271929 [details]
Patch
Comment 11 Geoffrey Garen 2016-02-22 11:33:20 PST 
Comment on attachment 271929 [details]
Patch

r=me
Comment 12 WebKit Commit Bot 2016-02-22 12:07:47 PST 
Comment on attachment 271929 [details]
Patch

Clearing flags on attachment: 271929

Committed r196950: <http://trac.webkit.org/changeset/196950>
Comment 13 WebKit Commit Bot 2016-02-22 12:07:51 PST 
All reviewed patches have been landed.  Closing bug.