Bug 153375 - Modern IDB: Implement put, get, and delete records for the SQLite backend
Summary: Modern IDB: Implement put, get, and delete records for the SQLite backend
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 149117 153021
  Show dependency tree / graph
 
Reported: 2016-01-22 14:51 PST by Brady Eidson
Modified: 2016-01-22 16:41 PST (History)
4 users (show)

See Also:

Attachments
Patch v1 (29.30 KB, patch)
2016-01-22 14:54 PST, Brady Eidson 		achristensen: review+
Details | Formatted Diff | Diff
Patch for landing (29.30 KB, patch)
2016-01-22 15:12 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2016-01-22 14:51:13 PST 
Modern IDB: Implement put, get, and delete records for the SQLite backend
Comment 1 Brady Eidson 2016-01-22 14:54:01 PST 
Created attachment 269614 [details]
Patch v1
Comment 2 Alex Christensen 2016-01-22 15:03:56 PST 
Comment on attachment 269614 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=269614&action=review

> Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:687
> +        keyExists = false;

This isn't necessary.  It was already set to false.
Comment 3 Brady Eidson 2016-01-22 15:12:22 PST 
Created attachment 269615 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2016-01-22 16:41:17 PST 
Comment on attachment 269615 [details]
Patch for landing

Clearing flags on attachment: 269615

Committed r195495: <http://trac.webkit.org/changeset/195495>
Comment 5 WebKit Commit Bot 2016-01-22 16:41:20 PST 
All reviewed patches have been landed.  Closing bug.