Bug 153359 - Modern IDB: Add transactions and create/delete object store to SQLite backend
Summary: Modern IDB: Add transactions and create/delete object store to SQLite backend
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 149117 153021
  Show dependency tree / graph
 
Reported: 2016-01-22 10:33 PST by Brady Eidson
Modified: 2016-01-22 12:37 PST (History)
4 users (show)

See Also:

Attachments
Patch v1 (47.48 KB, patch)
2016-01-22 10:47 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch v2 (47.52 KB, patch)
2016-01-22 11:22 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2016-01-22 10:33:13 PST 
Modern IDB: Add transactions and create/delete object store to SQLite backend
Comment 1 Brady Eidson 2016-01-22 10:47:29 PST 
Created attachment 269581 [details]
Patch v1

This patch makes a few tests fail worse than they used to (text failure becomes timeout/ASSERT), but that's okay - It's expected that the tests are still very rough at this stage.

The handful of regressions is more than offset by the many tests that now pass.
Comment 2 Brady Eidson 2016-01-22 11:22:28 PST 
Created attachment 269590 [details]
Patch v2
Comment 3 Alex Christensen 2016-01-22 11:46:47 PST 
Comment on attachment 269581 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=269581&action=review

> Source/WebCore/Modules/indexeddb/server/MemoryIDBBackingStore.cpp:478
> +    auto objectStore = m_objectStoresByName.take(objectStoreByIdentifier->info().name());

This is unused.
Comment 4 WebKit Commit Bot 2016-01-22 12:37:53 PST 
Comment on attachment 269590 [details]
Patch v2

Clearing flags on attachment: 269590

Committed r195467: <http://trac.webkit.org/changeset/195467>
Comment 5 WebKit Commit Bot 2016-01-22 12:37:58 PST 
All reviewed patches have been landed.  Closing bug.