Bug 153356 – Style resolver initialization cleanups

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Antti Koivisto]

Simplify StyleResolver::State initialization.

[Antti Koivisto]

Created attachment 269577 [details]
patch

[Simon Fraser (smfr)]

Comment on attachment 269577 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=269577&action=review

> Source/WebCore/css/StyleResolver.h:453
> -        EInsideLink m_elementLinkState;
> +        EInsideLink m_elementLinkState { NotInsideLink };
>  
> -        bool m_elementAffectedByClassRules;
> +        bool m_elementAffectedByClassRules { false };
>  
> -        bool m_applyPropertyToRegularStyle;
> -        bool m_applyPropertyToVisitedLinkStyle;
> +        bool m_applyPropertyToRegularStyle { true };
> +        bool m_applyPropertyToVisitedLinkStyle { false };
>  
>          PendingImagePropertyMap m_pendingImageProperties;
>  
>          Vector<RefPtr<ReferenceFilterOperation>> m_filtersWithPendingSVGDocuments;
>  
> -        bool m_fontDirty;
> -        bool m_fontSizeHasViewportUnits;
> +        bool m_fontDirty { false };
> +        bool m_fontSizeHasViewportUnits { false };
>  
> -        bool m_hasUAAppearance;
> +        bool m_hasUAAppearance { false };
>          BorderData m_borderData;
> -        FillLayer m_backgroundData;
> +        FillLayer m_backgroundData { BackgroundFillLayer };
>          Color m_backgroundColor;

Would be nice to pack all the bools and small enums together to save space.

[Build Bot]

Comment on attachment 269577 [details]
patch

Attachment 269577 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/726167

New failing tests:
imported/blink/printing/print-document-without-documentElement-crash.html

[Build Bot]

Created attachment 269582 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 269577 [details]
patch

Attachment 269577 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/726162

New failing tests:
imported/blink/printing/print-document-without-documentElement-crash.html

[Build Bot]

Created attachment 269585 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Antti Koivisto]

Created attachment 269587 [details]
for bots

[Antti Koivisto]

https://trac.webkit.org/r195465