Bug 153330 – Fix bugs caused by incorrect usage of "branch" vs. "branchName".

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jason Marcell]

Fix bugs caused by incorrect usage of "branch" vs. "branchName".

[Jason Marcell]

Created attachment 269517 [details]
Patch

[Jason Marcell]

Created attachment 269586 [details]
Patch

[Dean Johnson]

Comment on attachment 269586 [details]
Patch

r=me!

[Daniel Bates]

Comment on attachment 269586 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=269586&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:113
> +    _popoverLinesForCommitRange: function(trac, branch, firstRevisionNumber, lastRevisionNumber)

I'm assuming you plan to make more use of the branch object in a subsequent patch than to get the branch name. Currently this function only makes use of the branch name.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js:115
> +    var branch = this.trunkBranch;

This variable is used exactly once and I do not feel that its name makes the purpose of this variable any more understandable than its values. I suggest that we inline the value of this variable into the line below (line 116) and remove this variable.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js:129
> +    var branch = this.trunkBranch;

By a similar argument as above, I suggest inlining the value of this variable where its referenced and remove this variable.

[Jason Marcell]

Comment on attachment 269586 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=269586&action=review

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:113
>> +    _popoverLinesForCommitRange: function(trac, branch, firstRevisionNumber, lastRevisionNumber)
> 
> I'm assuming you plan to make more use of the branch object in a subsequent patch than to get the branch name. Currently this function only makes use of the branch name.

That's correct. I do have a forthcoming patch that will make use of properties other than the branch name.

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js:115
>> +    var branch = this.trunkBranch;
> 
> This variable is used exactly once and I do not feel that its name makes the purpose of this variable any more understandable than its values. I suggest that we inline the value of this variable into the line below (line 116) and remove this variable.

Will do.

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js:129
>> +    var branch = this.trunkBranch;
> 
> By a similar argument as above, I suggest inlining the value of this variable where its referenced and remove this variable.

Will do.

[Jason Marcell]

Landed: http://trac.webkit.org/changeset/195690