Bug 153328 - Use credentials from a URL with NetworkSession like we did with ResourceHandle
Summary: Use credentials from a URL with NetworkSession like we did with ResourceHandle
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-21 15:41 PST by Alex Christensen
Modified: 2016-01-23 01:44 PST (History)
2 users (show)

See Also:


Attachments
Patch (19.24 KB, patch)
2016-01-21 15:45 PST, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (24.93 KB, patch)
2016-01-22 13:38 PST, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (12.65 KB, patch)
2016-01-22 16:49 PST, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-01-21 15:41:17 PST
Use CredentialStorage with NetworkSession like we did with ResourceHandle
Comment 1 Alex Christensen 2016-01-21 15:45:24 PST
Created attachment 269507 [details]
Patch
Comment 2 Alexey Proskuryakov 2016-01-22 12:12:15 PST
I hoped that we would get rid of CredentialStorage when using NetworkSession, it's an abomination.
Comment 3 Alex Christensen 2016-01-22 13:38:27 PST
Created attachment 269601 [details]
Patch
Comment 4 Alex Christensen 2016-01-22 13:38:55 PST
Comment on attachment 269601 [details]
Patch

This patch was uploading buggy WIP before trying another approach.
Comment 5 Alex Christensen 2016-01-22 16:49:05 PST
Created attachment 269622 [details]
Patch
Comment 6 WebKit Commit Bot 2016-01-23 01:44:20 PST
Comment on attachment 269622 [details]
Patch

Clearing flags on attachment: 269622

Committed r195509: <http://trac.webkit.org/changeset/195509>
Comment 7 WebKit Commit Bot 2016-01-23 01:44:24 PST
All reviewed patches have been landed.  Closing bug.