Bug 153326 - [iOS] Crash in _endPotentialTapAndEnableDoubleTapGesturesIfNecessary
Summary: [iOS] Crash in _endPotentialTapAndEnableDoubleTapGesturesIfNecessary
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-21 14:44 PST by Dean Jackson
Modified: 2016-01-21 15:36 PST (History)
0 users

See Also:

Attachments
Patch (3.75 KB, patch)
2016-01-21 15:07 PST, Dean Jackson 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2016-01-21 14:44:42 PST 
We're getting a lot of reports of crashes in
-[WKContentView(WKInteraction) _endPotentialTapAndEnableDoubleTapGesturesIfNecessary]

<rdar://problem/24264339>
Comment 1 Dean Jackson 2016-01-21 15:07:11 PST 
Created attachment 269500 [details]
Patch
Comment 2 Anders Carlsson 2016-01-21 15:17:05 PST 
Comment on attachment 269500 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=269500&action=review

> Source/WebKit2/UIProcess/ios/WKContentView.h:78
> +- (void)_disconnectWebView;

Maybe call this _webViewDestroyed instead?

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1259
> -    if (_webView._allowsDoubleTapGestures)
> +    if (_webView && _webView._allowsDoubleTapGestures)

No need to check _webView for nil here. _allowsDoubleTapGestures will return false if _webView is nil.
Comment 3 Dean Jackson 2016-01-21 15:36:49 PST 
Committed r195424: <http://trac.webkit.org/changeset/195424>