Bug 153324 - [JSC] foldPathConstants() makes invalid assumptions with Switch
Summary: [JSC] foldPathConstants() makes invalid assumptions with Switch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-21 14:32 PST by Benjamin Poulain
Modified: 2016-01-21 14:56 PST (History)
5 users (show)

See Also:


Attachments
Patch (6.49 KB, patch)
2016-01-21 14:38 PST, Benjamin Poulain
no flags Details | Formatted Diff | Diff
Patch (6.44 KB, patch)
2016-01-21 14:51 PST, Benjamin Poulain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2016-01-21 14:32:38 PST
[JSC] foldPathConstants() makes invalid assumptions with Switch
Comment 1 Benjamin Poulain 2016-01-21 14:38:21 PST
Created attachment 269494 [details]
Patch
Comment 2 Filip Pizlo 2016-01-21 14:39:58 PST
Comment on attachment 269494 [details]
Patch

Please don't do this.  Switch needs to be revealed to tail duplication in order to get benefits on chains of MultiGetByOffset/MultiPutByOffset.
Comment 3 Benjamin Poulain 2016-01-21 14:51:57 PST
Created attachment 269497 [details]
Patch
Comment 4 Benjamin Poulain 2016-01-21 14:56:29 PST
Comment on attachment 269497 [details]
Patch

Clearing flags on attachment: 269497

Committed r195422: <http://trac.webkit.org/changeset/195422>
Comment 5 Benjamin Poulain 2016-01-21 14:56:32 PST
All reviewed patches have been landed.  Closing bug.