WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
153320
Add the ability to update WebKitAdditions to WK2
https://bugs.webkit.org/show_bug.cgi?id=153320
Summary
Add the ability to update WebKitAdditions to WK2
Beth Dakin
Reported
2016-01-21 13:46:27 PST
Add the ability to update WebKitAdditions to WK2
rdar://problem/23639629
Attachments
Patch
(7.67 KB, patch)
2016-01-21 13:48 PST
,
Beth Dakin
andersca
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Beth Dakin
Comment 1
2016-01-21 13:48:26 PST
Created
attachment 269487
[details]
Patch
WebKit Commit Bot
Comment 2
2016-01-21 13:49:42 PST
Attachment 269487
[details]
did not pass style-queue: ERROR: Source/WebKit2/UIProcess/Cocoa/WebViewImpl.h:478: The parameter name "string" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/UIProcess/Cocoa/WebViewImpl.h:478: The parameter name "view" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Beth Dakin
Comment 3
2016-01-21 13:52:46 PST
Thanks!!
http://trac.webkit.org/changeset/195421
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug