Bug 153297 - Revert to dispatching the popstate event synchronously
Summary: Revert to dispatching the popstate event synchronously
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-01-20 19:11 PST by Andy Estes
Modified: 2016-02-19 01:29 PST (History)
12 users (show)

See Also:


Attachments
Patch (6.01 KB, patch)
2016-01-20 19:29 PST, Andy Estes
bfulgham: review+
bfulgham: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2016-01-20 19:11:26 PST
Re-enable synchronous popstate event for safari-601-branch
Comment 1 Andy Estes 2016-01-20 19:11:57 PST
rdar://problem/24154417
Comment 2 Andy Estes 2016-01-20 19:29:56 PST
Created attachment 269416 [details]
Patch
Comment 3 Brent Fulgham 2016-01-21 10:13:16 PST
Comment on attachment 269416 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=269416&action=review

r=me. This should only be landed in the branch.

> LayoutTests/fast/loader/stateobjects/popstate-is-asynchronous-expected.txt:-8
> -Set hash to #foo

It seems weird that we don't output this. Surely the "Set hash to #foo" step is being taken, right?
Comment 4 Andy Estes 2016-01-21 17:44:18 PST
Comment on attachment 269416 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=269416&action=review

>> LayoutTests/fast/loader/stateobjects/popstate-is-asynchronous-expected.txt:-8
>> -Set hash to #foo
> 
> It seems weird that we don't output this. Surely the "Set hash to #foo" step is being taken, right?

It is weird, but expected. The popstate event handler finishes the test when it fires in response to setting location.hash to "#foo". With synchronous event dispatch, that means the test finishes before we get to the next line that logs "Set hash to #foo".
Comment 5 Andy Estes 2016-02-19 01:29:41 PST
Committed r196807: <http://trac.webkit.org/changeset/196807>