Bug 153295 - Remove irrelevant controls from open source flakiness dashboard and do a minor UI cleanup
Summary: Remove irrelevant controls from open source flakiness dashboard and do a mino...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Dean Johnson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-20 17:28 PST by Dean Johnson
Modified: 2016-08-04 17:47 PDT (History)
3 users (show)

See Also:

Attachments
Patch (7.05 KB, patch)
2016-01-20 18:59 PST, Dean Johnson 		no flags Details | Formatted Diff | Diff
Before patch (1.63 MB, image/png)
2016-01-21 11:55 PST, Dean Johnson 		no flags Details
After patch (1.68 MB, image/png)
2016-01-21 11:55 PST, Dean Johnson 		no flags Details
Patch (7.51 KB, patch)
2016-08-04 17:11 PDT, Dean Johnson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Johnson 2016-01-20 17:28:17 PST 
Frankly, the current UI hasn't had much work or had much maintenance since the Blink fork. There's dropdowns with only one option (Group: [TOT WebKit], Test type: [layout-tests]), text is misleading/unclear and formatted poorly, and generally speaking the dashboard is somewhat unpleasant to look at.

Let's see what we can do to improve the aesthetics of the UI.
Comment 1 Dean Johnson 2016-01-20 18:59:23 PST 
Created attachment 269413 [details]
Patch
Comment 2 Dean Johnson 2016-01-21 11:55:25 PST 
Created attachment 269477 [details]
Before patch
Comment 3 Dean Johnson 2016-01-21 11:55:46 PST 
Created attachment 269478 [details]
After patch
Comment 4 Dean Johnson 2016-01-21 11:59:44 PST 
Added some before/after pictures of the webpage.

Also, the rationale behind leaving the Test type: dropdown with only the layout-test option is that I think it's totally plausible to have other tests types on the dashboard in the future, even if we don't now. If this is something we really don't expect and really is just clutter on the page, I'm fine removing it.
Comment 5 Dean Johnson 2016-01-21 14:27:49 PST 
Updated title to more accurately reflect the purpose of what this bug should be tracking.
Comment 6 Darin Adler 2016-01-22 09:29:48 PST 
Comment on attachment 269413 [details]
Patch

Looks OK.
Comment 7 Dean Johnson 2016-08-04 17:11:31 PDT 
Created attachment 285382 [details]
Patch
Comment 8 WebKit Commit Bot 2016-08-04 17:47:27 PDT 
Comment on attachment 285382 [details]
Patch

Clearing flags on attachment: 285382

Committed r204156: <http://trac.webkit.org/changeset/204156>
Comment 9 WebKit Commit Bot 2016-08-04 17:47:31 PDT 
All reviewed patches have been landed.  Closing bug.