Bug 153292 – AX: [IOS] Implement next/previous text marker functions using TextIterator

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Nan Wang]

Try to use TextIterator class to refactor the next/previous text marker functions on iOS. And also make text marker tests working on iOS.

[Radar WebKit Bug Importer]

<rdar://problem/24268243>

[Nan Wang]

Created attachment 269409 [details]
patch

[chris fleizach]

Comment on attachment 269409 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=269409&action=review

> Source/WebCore/ChangeLog:11
> +        Also, fixed an issue in AXObjectCache that creating a range with a replaced node

AXObjectCache that creating - >AXObjectCache where creating

did you add a test case for this issue you fixed?

> Source/WebCore/accessibility/AXObjectCache.cpp:1551
> +    

remove unused line

> Source/WebCore/accessibility/AXObjectCache.cpp:1577
> +    bool startNodeIsReplacedOrBR = AccessibilityObject::replacedNodeNeedsCharacter(startNode) || startNode->hasTagName(brTag);

can you put this code block in a helper method

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:2506
> +    if (!start || !end)

can you make a helper method in WebAccessibilityTextMarker that takes a Range and returns an array of the WebAccessibilityTextMarker

> Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm:485
> +    return 0;

return nullptr;

> Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm:490
> +    return 0;

return nullptr;

> Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm:495
> +    return 0;

return nullptr;

> Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm:535
> +    return 0;

return nullptr;

[Nan Wang]

Comment on attachment 269409 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=269409&action=review

Will address these comments. Thanks.

>> Source/WebCore/ChangeLog:11
>> +        Also, fixed an issue in AXObjectCache that creating a range with a replaced node
> 
> AXObjectCache that creating - >AXObjectCache where creating
> 
> did you add a test case for this issue you fixed?

Yes, it's covered in the test when calling textMarkerRangeForMarkers.

[Nan Wang]

Created attachment 269411 [details]
patch

review comments

[WebKit Commit Bot]

Comment on attachment 269411 [details]
patch

Clearing flags on attachment: 269411

Committed r195405: <http://trac.webkit.org/changeset/195405>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.