Bug 153274 - [jhbuild] build error in LLVM OCaml bindings
Summary: [jhbuild] build error in LLVM OCaml bindings
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Frédéric Wang (:fredw)
Depends on: 155369
  Show dependency treegraph
Reported: 2016-01-20 04:52 PST by Frédéric Wang (:fredw)
Modified: 2016-03-11 10:54 PST (History)
8 users (show)

See Also:

Patch disabling OCaml bindings (948 bytes, patch)
2016-01-20 04:52 PST, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch (1.63 KB, patch)
2016-03-02 03:04 PST, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch (2.51 KB, patch)
2016-03-02 09:50 PST, Frédéric Wang (:fredw)
cgarcia: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2016-01-20 04:52:39 PST
Created attachment 269350 [details]
Patch disabling OCaml bindings

On Debian testing, update-webkitgtk-libs fails to build LLVM. The failure happens when compiling llvm_executionengine.ml with the error

"Error: Unbound value Ctypes.raw_address_of_ptr"

One workaround is to disable the OCaml bindings (see for example https://github.com/Homebrew/homebrew/commit/c246ee22c19e5c97d3c6b311877dc0aca342bae1) but I'm not sure whether this is problematic for WebKit's need, though.
Comment 1 Frédéric Wang (:fredw) 2016-03-02 03:04:34 PST
Created attachment 272653 [details]
Comment 2 Frédéric Wang (:fredw) 2016-03-02 03:05:01 PST
I still have this problem. I'm not sure whether I'm the only one but I'm asking review to at least get feedback on whether OCaml binding is really needed for WebKit. If it's not then it's safe to take this patch, that will solve my problem and even speed-up update-webkitgtk-libs for everybody.
Comment 3 Csaba Osztrogonác 2016-03-02 06:08:56 PST
Shouldn't we simply remove llvm from jhbuild?

Now FTL JIT uses B3 and all LLVM related thing
was removed from the trunk.
Comment 4 Michael Catanzaro 2016-03-02 08:16:26 PST
Comment on attachment 272653 [details]

Yes, please just remove llvm, nothing needs it anymore.
Comment 5 Frédéric Wang (:fredw) 2016-03-02 09:50:26 PST
Created attachment 272662 [details]
Comment 6 Frédéric Wang (:fredw) 2016-03-02 22:37:28 PST
Committed r197495: <http://trac.webkit.org/changeset/197495>
Comment 7 Michael Catanzaro 2016-03-11 09:56:59 PST
joanie:  mcatanzaro: (or anyone) http://www.fpaste.org/337290/18831145/
joanie:  look familiar and/or hints?
mcatanzaro:  joanie: Ooops, it's my fault
mcatanzaro:  I told fwang to remove llvm from our internal jhbuild, because WebKit no longer diirectly depends on LLVM. I said "nothing depends on it anymore"
mcatanzaro:  joanie: But we still need it, else it's a crapshoot whether mesa will build, because LLVM has no stable API.
mcatanzaro:  The problem is the mesa is our jhbuild environment is way too old for the LLVM in Fedora 24
joanie:  i downgraded this machine to f23
joanie:  and figured it was something I did
mcatanzaro:  joanie: It's probably too old for the LLVM in F23, then
Comment 8 Michael Catanzaro 2016-03-11 09:57:35 PST
joanie:  so what do you suggest?
mcatanzaro:  joanie: I'm gonna roll out the change that broke it, then fwang can submit another patch
joanie:  thank you
Comment 9 WebKit Commit Bot 2016-03-11 10:00:19 PST
Re-opened since this is blocked by bug 155369
Comment 10 WebKit Commit Bot 2016-03-11 10:52:38 PST
Comment on attachment 272653 [details]

Clearing flags on attachment: 272653

Committed r198029: <http://trac.webkit.org/changeset/198029>