RESOLVED FIXED Bug 153274
[jhbuild] build error in LLVM OCaml bindings 
https://bugs.webkit.org/show_bug.cgi?id=153274
Summary [jhbuild] build error in LLVM OCaml bindings
Frédéric Wang (:fredw)
Reported 2016-01-20 04:52:39 PST
Created attachment 269350 [details] Patch disabling OCaml bindings On Debian testing, update-webkitgtk-libs fails to build LLVM. The failure happens when compiling llvm_executionengine.ml with the error "Error: Unbound value Ctypes.raw_address_of_ptr" One workaround is to disable the OCaml bindings (see for example https://github.com/Homebrew/homebrew/commit/c246ee22c19e5c97d3c6b311877dc0aca342bae1) but I'm not sure whether this is problematic for WebKit's need, though.
Attachments
Patch disabling OCaml bindings (948 bytes, patch)
2016-01-20 04:52 PST, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
Patch (1.63 KB, patch)
2016-03-02 03:04 PST, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
Patch (2.51 KB, patch)
2016-03-02 09:50 PST, Frédéric Wang (:fredw) 		cgarcia: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Frédéric Wang (:fredw)
Comment 1 2016-03-02 03:04:34 PST
Created attachment 272653 [details] Patch
Frédéric Wang (:fredw)
Comment 2 2016-03-02 03:05:01 PST
I still have this problem. I'm not sure whether I'm the only one but I'm asking review to at least get feedback on whether OCaml binding is really needed for WebKit. If it's not then it's safe to take this patch, that will solve my problem and even speed-up update-webkitgtk-libs for everybody.
Csaba Osztrogonác
Comment 3 2016-03-02 06:08:56 PST
Shouldn't we simply remove llvm from jhbuild? Now FTL JIT uses B3 and all LLVM related thing was removed from the trunk.
Michael Catanzaro
Comment 4 2016-03-02 08:16:26 PST
Comment on attachment 272653 [details] Patch Yes, please just remove llvm, nothing needs it anymore.
Frédéric Wang (:fredw)
Comment 5 2016-03-02 09:50:26 PST
Created attachment 272662 [details] Patch
Frédéric Wang (:fredw)
Comment 6 2016-03-02 22:37:28 PST
Committed r197495: <http://trac.webkit.org/changeset/197495>
Michael Catanzaro
Comment 7 2016-03-11 09:56:59 PST
joanie: mcatanzaro: (or anyone) http://www.fpaste.org/337290/18831145/ joanie: look familiar and/or hints? mcatanzaro: joanie: Ooops, it's my fault mcatanzaro: I told fwang to remove llvm from our internal jhbuild, because WebKit no longer diirectly depends on LLVM. I said "nothing depends on it anymore" mcatanzaro: joanie: But we still need it, else it's a crapshoot whether mesa will build, because LLVM has no stable API. mcatanzaro: The problem is the mesa is our jhbuild environment is way too old for the LLVM in Fedora 24 joanie: i downgraded this machine to f23 joanie: and figured it was something I did mcatanzaro: joanie: It's probably too old for the LLVM in F23, then
Michael Catanzaro
Comment 8 2016-03-11 09:57:35 PST
joanie: so what do you suggest? mcatanzaro: joanie: I'm gonna roll out the change that broke it, then fwang can submit another patch joanie: thank you
WebKit Commit Bot
Comment 9 2016-03-11 10:00:19 PST
Re-opened since this is blocked by bug 155369
WebKit Commit Bot
Comment 10 2016-03-11 10:52:38 PST
Comment on attachment 272653 [details] Patch Clearing flags on attachment: 272653 Committed r198029: <http://trac.webkit.org/changeset/198029>
Note You need to log in before you can comment on or make changes to this bug.