Bug 153264 - DocumentType.publicId / systemId should never return null
Summary: DocumentType.publicId / systemId should never return null
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://dom.spec.whatwg.org/#interfac...
Keywords: WebExposed
Depends on:
Blocks:
 
Reported: 2016-01-19 18:29 PST by Chris Dumez
Modified: 2016-07-25 12:20 PDT (History)
5 users (show)

See Also:

Attachments
Patch (16.58 KB, patch)
2016-01-19 18:33 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-01-19 18:29:47 PST 
DocumentType.publicId / systemId should never return null as these attributes are not nullable in the IDL:
https://dom.spec.whatwg.org/#interface-documenttype

Instead we should return the empty string. Firefox and Chrome match the specification.
Comment 1 Chris Dumez 2016-01-19 18:33:16 PST 
Created attachment 269324 [details]
Patch
Comment 2 WebKit Commit Bot 2016-01-19 20:06:41 PST 
Comment on attachment 269324 [details]
Patch

Clearing flags on attachment: 269324

Committed r195336: <http://trac.webkit.org/changeset/195336>
Comment 3 WebKit Commit Bot 2016-01-19 20:06:49 PST 
All reviewed patches have been landed.  Closing bug.