AX: ARIA combo boxes are not returning the right value for selected text range

[chris fleizach]

If you have an ARIA combo box it does not return the right value for selected text range because we have code to NOT do that for aria things

But we should respect ARIA controls that ARE text elements.

<rdar://problem/24219086>

[chris fleizach]

Created attachment 269313 [details]
patch

[Build Bot]

Comment on attachment 269313 [details]
patch

Attachment 269313 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/714703

New failing tests:
accessibility/textarea-insertion-point-line-number.html
accessibility/textarea-selected-text-range.html

[Build Bot]

Created attachment 269316 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 269313 [details]
patch

Attachment 269313 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/714730

New failing tests:
accessibility/textarea-insertion-point-line-number.html
accessibility/textarea-selected-text-range.html

[Build Bot]

Created attachment 269318 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 269313 [details]
patch

Attachment 269313 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/714731

New failing tests:
accessibility/textarea-selected-text-range.html
accessibility/textarea-insertion-point-line-number.html

[Build Bot]

Created attachment 269320 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Darin Adler]

Comment on attachment 269313 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=269313&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1497
> +    // Use the text control native range if it's a native object and it has no ARIA role (or has a text based ARIA role).
> +    if (isNativeTextControl() && (ariaRole != UnknownRole || isARIATextControl())) {

Comment makes it sound like this should be == UnknownRole rather than != UnknownRole. Do we have test coverage for this? I think perhaps that’s why tests are failing?

[chris fleizach]

Comment on attachment 269313 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=269313&action=review

>> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1497
>> +    if (isNativeTextControl() && (ariaRole != UnknownRole || isARIATextControl())) {
> 
> Comment makes it sound like this should be == UnknownRole rather than != UnknownRole. Do we have test coverage for this? I think perhaps that’s why tests are failing?

yep, that's why these tests are failing. messed up the logic before uploading.

[chris fleizach]

Created attachment 269355 [details]
patch

[WebKit Commit Bot]

Comment on attachment 269355 [details]
patch

Clearing flags on attachment: 269355

Committed r195457: <http://trac.webkit.org/changeset/195457>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.