WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
15326
innerHTML updates layout every time (hurts celtickane JS benchmark)
https://bugs.webkit.org/show_bug.cgi?id=15326
Summary
innerHTML updates layout every time (hurts celtickane JS benchmark)
Maciej Stachowiak
Reported
2007-09-30 02:19:30 PDT
innerHTML updates layout every time it is read. This can be seen on "
http://celtickane.com/projects/jsspeed2007.php
", where on the DOM test (actually primarily a test of innerHTML) we are currently the slowest of any browser.
Attachments
don't update layout for innerHTML
(1.14 KB, patch)
2007-09-30 02:21 PDT
,
Maciej Stachowiak
eric
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Maciej Stachowiak
Comment 1
2007-09-30 02:21:42 PDT
Created
attachment 16467
[details]
don't update layout for innerHTML
Eric Seidel (no email)
Comment 2
2007-09-30 06:48:22 PDT
Comment on
attachment 16467
[details]
don't update layout for innerHTML I also looked, it appears that createMarkup(Node*... does not actually touch the render tree (renderer()) so I agree, this looks safe. r=me
Maciej Stachowiak
Comment 3
2007-10-02 01:23:10 PDT
Incidentally this patch is a 65% speedup on that one test in the benchmark.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug