Bug 153258 - Web Inspector: Uncaught exception when logging an Error object
Summary: Web Inspector: Uncaught exception when logging an Error object
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-01-19 16:39 PST by Joseph Pecoraro
Modified: 2016-01-19 22:22 PST (History)
8 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (2.57 KB, patch)
2016-01-19 16:43 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[IMAGE] After Change (109.95 KB, image/png)
2016-01-19 16:43 PST, Joseph Pecoraro 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-01-19 16:39:21 PST 
* SUMMARY
Uncaught exception when logging an Error object.

* STEPS TO REPRODUCE
1. js> try { ({}).x.x } catch (e) { j = e; console.log(e); }
2. js> j
  => nothing

* NOTES
- Uncaught exception trying to call appendTitleSuffix on an ErrorObjectView. ErrorObjectView doesn't implement ObjectView's full API.
Comment 1 Radar WebKit Bug Importer 2016-01-19 16:39:37 PST 
<rdar://problem/24249068>
Comment 2 Joseph Pecoraro 2016-01-19 16:43:19 PST 
Created attachment 269308 [details]
[PATCH] Proposed Fix
Comment 3 Joseph Pecoraro 2016-01-19 16:43:38 PST 
Created attachment 269309 [details]
[IMAGE] After Change
Comment 4 Nikita Vasilyev 2016-01-19 18:22:55 PST 
Good find! Looks like I didn't test for this case in
http://trac.webkit.org/changeset/188017

I looked at the patch and it looks good. I'd r+ if I were a reviewer.
Comment 5 WebKit Commit Bot 2016-01-19 22:22:32 PST 
Comment on attachment 269308 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 269308

Committed r195344: <http://trac.webkit.org/changeset/195344>
Comment 6 WebKit Commit Bot 2016-01-19 22:22:37 PST 
All reviewed patches have been landed.  Closing bug.