Bug 153254 - Move away from NSSpellChecker's showCandidates method
Summary: Move away from NSSpellChecker's showCandidates method
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-19 14:42 PST by Beth Dakin
Modified: 2016-01-19 16:57 PST (History)
1 user (show)

See Also:

Attachments
Patch (3.15 KB, patch)
2016-01-19 14:46 PST, Beth Dakin 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2016-01-19 14:42:55 PST 
Move away from NSSpellChecker's showCandidates method

rdar://problem/24216292
Comment 1 Beth Dakin 2016-01-19 14:46:00 PST 
Created attachment 269299 [details]
Patch
Comment 2 WebKit Commit Bot 2016-01-19 14:47:51 PST 
Attachment 269299 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm:1172:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Beth Dakin 2016-01-19 16:47:59 PST 
Thanks Tim! http://trac.webkit.org/changeset/195324
Comment 4 Beth Dakin 2016-01-19 16:57:21 PST 
Build fix for 32 bit: 195327