WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
153240
Use references in SelectorChecker
https://bugs.webkit.org/show_bug.cgi?id=153240
Summary
Use references in SelectorChecker
Antti Koivisto
Reported
2016-01-19 10:42:51 PST
Element and selector can't be null in most places.
Attachments
patch
(39.92 KB, patch)
2016-01-19 10:44 PST
,
Antti Koivisto
kling
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Antti Koivisto
Comment 1
2016-01-19 10:44:49 PST
Created
attachment 269271
[details]
patch
WebKit Commit Bot
Comment 2
2016-01-19 10:47:40 PST
Attachment 269271
[details]
did not pass style-queue: ERROR: Source/WebCore/css/SelectorChecker.cpp:623: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Antti Koivisto
Comment 3
2016-01-19 13:27:25 PST
https://trac.webkit.org/r195311
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug