Bug 153240 - Use references in SelectorChecker
Summary: Use references in SelectorChecker
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-19 10:42 PST by Antti Koivisto
Modified: 2016-01-19 13:27 PST (History)
1 user (show)

See Also:


Attachments
patch (39.92 KB, patch)
2016-01-19 10:44 PST, Antti Koivisto
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2016-01-19 10:42:51 PST
Element and selector can't be null in most places.
Comment 1 Antti Koivisto 2016-01-19 10:44:49 PST
Created attachment 269271 [details]
patch
Comment 2 WebKit Commit Bot 2016-01-19 10:47:40 PST
Attachment 269271 [details] did not pass style-queue:


ERROR: Source/WebCore/css/SelectorChecker.cpp:623:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Antti Koivisto 2016-01-19 13:27:25 PST
https://trac.webkit.org/r195311